-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RingProgress should not render Tooltip if no tooltip is provieded #2220
Labels
Fixed
Completed issues that will be published with next patch (1.0.X)
Comments
This issue maybe related and could possibly be fixed in one go. |
rtivital
added a commit
that referenced
this issue
Aug 27, 2022
Fixed in 5.2.4 |
nmay231
pushed a commit
to nmay231/mantine
that referenced
this issue
Aug 28, 2022
@rtivital this is also a problem with the latest v6 release (6.0.21). Any idea how to prevent this? As soon as I render 4 RingProgress I get 12 portals (btw I'd expect 8, because I have 4 RingProgress components, 2 sections each). |
Applying the same solution as in #50d4e64 seems to fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What package has an issue
@mantine/core
Describe the bug
In our grid we render a large number of
RingProgress
components but did not providetooltip
in thesections
props, however in the code there is no way to avoid the extra tooltip components being rendered, results in a bunch of (hundreds of) empty divs in the page.What version of @mantine/hooks page do you have in package.json?
5.2.0
If possible, please include a link to a codesandbox with the reproduced problem
No response
Do you know how to fix the issue
No
Are you willing to participate in fixing this issue and create a pull request with the fix
Yes
Possible fix
Don't render anything for tooltip if it is disabled.
The text was updated successfully, but these errors were encountered: