Use ADSObserver in ContourPreviewPlot widget #37411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR ensures the ContourPreviewPlot widget uses the ADSObserver class to observe changes in the ADS. This makes the code simpler in the ContourPreviewPlot, and also helps avoid a bug as the ADSObserver class will make sure the previewplot is not subscribed to ADS notifications more than once. This has caused a crash in the past for other similar widgets: #37074
To test:
I have not found a crash for this widget. I think because the
watchADS
function is not called on the ContourPreviewPlot from outside the widget. Just do a simple test to make sure Inelastic S(Q,w) is still working:irs26176_graphite002_red
file from sample dataRun
. It should run without a crash or an errorThis does not require release notes because there is no user-facing change
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.