Fix regular live data crashes on OFFSPEC #36935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Summary of work
When live data is run for the OFFSPEC instrument from the ISIS Reflectometry GUI there seem to be regular crashes. In
ReflectometryReductionLiveData
we were supporting instruments using different Controls systems by looking up different values for OFFSPEC. OFFSPEC have recently switched to IBEX, so we can now look up their values the same way as for other instruments. This reduces the number of errors that are logged and, from testing on IDAaaS, it appears to improve the stability of live data on OFFSPEC.I am marking this PR as fixing the linked issue as I don't think there are any reproducible problems left on that ticket now.
Fixes #35400.
To test:
I have tested with Conda packages on IDAaaS because checking the impact on stability requires running it for some time while the beam is on. I ran live data for OFFSPEC in the Nightly alongside running it from the Conda packages and found that in just under 24 hours the Nightly version crashed twice while the Conda packages didn't crash at all. I wouldn't suggest that this be repeated when testing this PR, but the following will ensure that live data is still working OK. I can't seem to run live data on my machine when not plugged into the network on site so I can give installation details for the Conda packages, or share an IDAaaS workspace, if anyone needs to test there instead.
OFFSPEC
.Start monitor
button.Rather than the below errors, which you would have seen in the past when trying to read the s1v and s2v values for OFFSPEC:
INTER
to check that live data is still working OK for other instruments.Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.