Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep project recoveries from 6.9 onwards separate #36909

Closed
wants to merge 2 commits into from

Conversation

jclarkeSTFC
Copy link
Contributor

@jclarkeSTFC jclarkeSTFC commented Feb 21, 2024

The format of the project recovery folder changed in 6.9, see #36859. This PR changes the project recovery folder so that pre-6.9 and 6.9-onwards backups are kept separate. This fixes a bug where if you tried to start 6.9 with a backup from 6.8, Workbench would not open.

Description of work

  • Changed name of project recovery folder

To test:

Fixes #36900


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

The format of the folder changed in 6.9.
@jclarkeSTFC jclarkeSTFC added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Feb 21, 2024
@jclarkeSTFC jclarkeSTFC added this to the Release 6.9 milestone Feb 21, 2024
@jclarkeSTFC jclarkeSTFC marked this pull request as ready for review February 21, 2024 15:39
Copy link
Contributor

@thomashampson thomashampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something weird was happening when I tested this. I crashed 6.9 and 6.8, then recovered 6.9 successfully. But when I opened 6.8, it recovered the 6.9 workspaces from the ordered_recovery.py file, rather than looking in the workbench-recovery directory

@jclarkeSTFC
Copy link
Contributor Author

Got a better fix in #36914

@jclarkeSTFC jclarkeSTFC deleted the separate-new-project-recoveries branch February 22, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants