Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed individual release note files 6.6 #35225

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

jhaigh0
Copy link
Contributor

@jhaigh0 jhaigh0 commented Feb 16, 2023

Description of work.

Deleted the directory structure which holds the individual release note files so that just the main files are remaining.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@jhaigh0 jhaigh0 added the Documentation Issues and pull requests related to documentation label Feb 16, 2023
@jhaigh0 jhaigh0 added this to the Release 6.6 milestone Feb 16, 2023
Copy link
Contributor

@cailafinn cailafinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Checked the docs build and look right, just to be sure, and they do. Nice work 👍

@martyngigg martyngigg merged commit 54a39e0 into release-next Feb 16, 2023
@martyngigg martyngigg deleted the remove_release_note_file_structure branch February 16, 2023 10:44
@martyngigg
Copy link
Member

@gemmaguest @thomashampson The is has cleaned up the used release notes so the build should be ready to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants