Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options for text color, background color and darken #218

Closed
wants to merge 1 commit into from

Conversation

chrism
Copy link

@chrism chrism commented Jun 14, 2018

Hi,

Not sure if you are accepting PRs and if so whether this would conform but I thought I'd share it in case it's useful to someone else.

Due to the use of component css I found it awkward to try to update the styling independently using selectors (and I have a dynamic colour scheme).

I therefore thought it useful to introduce optional bgColor and textColor which can be passed in, along with an option to scheme the rest as dark, instead of the default light (this is important if the bgColor choice is very light).

Let me know what you think & I can update the docs, for example, too if you think it's appropriate.

Thanks for the great library!

PS: I also have a custom icon PR to submit along similar lines too

@chrism
Copy link
Author

chrism commented Jun 14, 2018

There is an open issue for something that looks similar I think
#58

@jacobq
Copy link
Contributor

jacobq commented Dec 6, 2018

I +1's this PR because I think this is a much needed feature, however, I think it should be made possible to do by overriding CSS / SCSS variables.

@mansona
Copy link
Owner

mansona commented Nov 12, 2019

Hey folks 👋 the new version of the addon will be removing CSS modules #251 (comment)

So if you don't mind I'm going to close this PR because you said Due to the use of component css 😂

Also yes we're accepting PRs 👍 I just want to simplify things and that's why I have removed CSS Modules because it seems to be creating a lot of friction for a lot of users 😞

@mansona mansona closed this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants