Added 'isDismissed' and jQuery.event arguments to #onClick #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump - would like to see this merged at some point 👍 @ynnoj |
|
+1 |
|
Closing in favour of similar PR within an up-to-date branch #203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that
onClickis called regardless of where the user clicks the notification, determining their goal was hard. Thenotificationobject returned byonClickdid not have the valuedismisson hand, asonClickran before the notification was dismissed. Therefore, I was running a timer afteronClickto see whether the user wanted to dismiss or interact. This also limited how many interactions we can add.I made this simple PR to return the jQuery event object as well as determine whether the user clicked the dismiss icon or elsewhere.