Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding TernoScans and ErosScan #7658

Merged
merged 9 commits into from
Feb 8, 2025
Merged

Adding TernoScans and ErosScan #7658

merged 9 commits into from
Feb 8, 2025

Conversation

Bazket571
Copy link
Contributor

No description provided.

@MikeZeDev
Copy link
Contributor

Hello. thanks for your contribution but are you aware those websites change domain like 2 times a week and it will be a pain to maintain ?

If you really want i can review the code, there are quite some things to fix :)

@Bazket571
Copy link
Contributor Author

Ofcourse you can review the code, is this what Github was made for?
Not gonna lie I made this for an one time download so I didn't aware they change their domain so frequently, but if we can somehow get the image link directly without the domain regex that would be great.
The image link is stored directly on the website in a script tag starts with ts_reader.run. Its in plain text for Eros but for Terno its in base64
For the site URL, I think all those domains are aliases to each other.

@Bazket571
Copy link
Contributor Author

Speak of the devil they just changed their domain

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Jan 12, 2025 •
edited
Loading

  1. Pay attention to indentation, use things like eslint
  2. Those sites use a theme we call "Mangastream" look for similar websites in source code base instead of reinventing the wheel :)

MikeZeDev
MikeZeDev requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@MikeZeDev MikeZeDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you do it like other MangaStream websites, and fix that ugly indentation ^^

src/web/mjs/connectors/Erosscan.mjs Outdated Show resolved Hide resolved
src/web/mjs/connectors/Erosscan.mjs Outdated Show resolved Hide resolved
src/web/mjs/connectors/Erosscan.mjs Outdated Show resolved Hide resolved
src/web/mjs/connectors/TernoScan.mjs Outdated Show resolved Hide resolved
src/web/mjs/connectors/TernoScan.mjs Outdated Show resolved Hide resolved
@MikeZeDev
Copy link
Contributor

Oh crap we alredy have a

hakuneko/src/web/mjs/connectors/TecnoScan.mjs

Line 4 in bfc6bb8

Replace this one.

@Bazket571
Copy link
Contributor Author

I think thats a different one. That tecno one is in spanish and this one is in english. Maybe its just tecno in the name, but the eros scan actually refer this as terno 😆

@MikeZeDev
Copy link
Contributor

I think thats a different one. That tecno one is in spanish and this one is in english. Maybe its just tecno in the name, but the eros scan actually refer this as terno 😆

The one i ma referring is dead and i am pretty sure terno was named tecno in the past.
Even according to previous domains. Thats a damn mess anyway, please just replace it so its accurate with Haruneko.

@MikeZeDev
Copy link
Contributor

Trailing "/" still needs to be removed and changes marked as "solved". I know its a bit formal but its a good practice not to let maintainers fix little things on PR ^^

MikeZeDev
MikeZeDev approved these changes Feb 6, 2025
View reviewed changes
src/web/mjs/connectors/Erosscan.mjs Outdated Show resolved Hide resolved
src/web/mjs/connectors/TernoScan.mjs Outdated Show resolved Hide resolved
src/web/mjs/connectors/Erosscan.mjs Outdated Show resolved Hide resolved
src/web/mjs/connectors/TernoScan.mjs Outdated Show resolved Hide resolved
src/web/mjs/connectors/Erosscan.mjs Outdated Show resolved Hide resolved
MikeZeDev
MikeZeDev requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@MikeZeDev MikeZeDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename eros files to match id

@MikeZeDev
Copy link
Contributor

Closing this on Marsh 01 in not solved.

@MikeZeDev MikeZeDev merged commit b67ab09 into manga-download:master Feb 8, 2025
@Bazket571 Bazket571 deleted the TernoScan branch February 8, 2025 15:47
Sheepux pushed a commit that referenced this pull request Feb 9, 2025
@Bazket571 @MikeZeDev @Sheepux
Adding TernoScans and ErosScan (#7658)
1d1df00 
* Adding TernoScans and ErosScan

Co-authored-by: MikeZeDev <MikeZeDev@users.noreply.github.com>
Sheepux added a commit that referenced this pull request Feb 9, 2025
@Sheepux @MikeZeDev
@akn19 @beer-psi @TristanWasTaken @aboudiom59 @noname2noname @Lapot300 @manga-download-owner @kiseki999 @Bazket571
Merge nightly stable (#7742)
52850a8 
* Siyahmelek: change domain (#7294)

Fixes #7293

* Fix lint on Siyahmelek.mjs (#7296)

* PixivComics: change endpoint & update hash algo (#7298)

minor changes

* add connector mikoroku (#7219)

* add connector mikoroku

* cleanup Mikoroku.mjs

* code updated

* fix clipboard

---------

Co-authored-by: MikeZeDev <MikeZeDev@users.noreply.github.com>

* CuuTruyen (#7307)

* CuuTruyen

* apply suggestions

* Ngomik: change domain (#7308)

* FIx GourmetScans: fix getting pages (#7324)

* FIx GourmetScans: fix getting pages

Fixes #7322

Same fix than Haruneko

* Update GourmetScans.mjs

* Update GourmetScans.mjs

* RuyaManga : cahnge domain (#7323)

Fixes #7321

* MoreNovel : change domain (#7315)

Fixes #7313

* Domains updates (#7328)

* Manhwaland: change domain

* Kiryuu: change domain

* KoMBatch change domain

* TempestScans: change domain (#7333)

Fixes #7331

* feat(RadiantScans): add connector (#7384)

https://radiantscans.com

* Desu : use referrer to download images (#7352)

* IrisScanlator: change Domain (#7347)

and use Mangastream not Mdara

* GriMelek change domain (#7370)

* Welovemanga.one : fix getting image (#7373)

simple change of dataset value

* Update SushiScans.mjs (#7388)

Just the link that changed it's catalogue instead of manga

* PixivComics : change salt (#7394)

Fixes #7393

* TruyenQQ : change domain (#7392)

* PixivComics: change salt again (#7397)

* PixivComics: change salt again

* always uses latest salt

* Update PixivComics.mjs

* MangaTale : change domain (#7399)

Fixes #7398

* PixivComics  : get salt from chapter JSON (#7402)

😞

* KomikIndo: change domain (#7420)

Fixes #7418

* TenshiID: change domain (#7432)

Fixes #7431

* Rackus (PMScans) : change domain (#7436)

Fixes #7435

* SamuraiScan: domain change (#7459)

Fixes #7454

* feat(Iken, VortexScans, MangaGalaxy): add Iken template (#7462)

* TukangKomik: update domain (#7486)

* MangaSwat: change domain (#7500)

FIxes #7494

* fix lints (#7505)

npm run lint

* fix title fetch and image fetch in hitomi (#7504)

Two observations:
- for some reason a direct DOM fetch from the request to get the title does not work (anymore). This is not related to the fetch but rather to the requested page itself, as the title element to be just gone (reproducable in curl). The suspicion I have is that there might be some javascript run afterwards that populates the title instead, hence resorting to js injection to get the title directly (unfortunate, but better than completely broken).
- the source code on the site for fetching images has changed, updating to be consistent to what is on the site.

* AllHentai: change domain (#7502)

Fixes #7499

* AresManga: change domain (#7501)

Fixes #7493

* OlympusScanlation: change domain (#7506)

and tiny api fix.

Fixes #7503

* update domains (#7507)

* Miauscan: change domain (#7520)

Fixes #7519

* TenshiID: update domain (#7529)

Closes #7527

* Add imperiodabritannia Connector (#7551)

* Add imperiodabritannia Connector

* Convert imperiodabritanio connector logo to correct format

* LikeManga : change domain (#7556)

* WebtoonHatti : change domain (#7572)

Closes #7570

* TCBScans: domain change (#7576)

Closes #7574

* BacaKomik: change domain (#7628)

* ComicBoost: fix getting pages (#7655)

thanks god a tiny fix.

Closes #7654

* WebtoonHatti: change domain (#7634)

Closes #7633

* Desu : update domain (#7665)

Closes #7664

* Komiku: fix getting pages (#7667)

Closes #7666

* Update Issue Templates (#7717)

* Update 2-suggest-a-new-connector-website.md

Add weebcentral info

* update wbesite issue template

* fix typo

* Manhuaga : Madara to MangaStream (#7701)

closes #7693

* Grimelel : change domain (#7689)

Closes #7688

* Add Weeb Central connector/website (#7720)

* Add Weeb Central connector

* Add weebcentral icon

* Update WeebCentral.mjs based on review

* Update WeebCentral.mjs, change "_getMangaFromURL"

* Yurineko: update domain (#7725)

Closes #7724

* MeioNovel: change domain (#7721)

Closes #7719

* Adding TernoScans and ErosScan (#7658)

* Adding TernoScans and ErosScan

Co-authored-by: MikeZeDev <MikeZeDev@users.noreply.github.com>

* Hivetoon: Change template (#7731)

* remove debug message

* InfernalVoidScan : use Iken template

---------

Co-authored-by: MikeZeDev <MikeZeDev@users.noreply.github.com>
Co-authored-by: akn19 <86169232+akn19@users.noreply.github.com>
Co-authored-by: beerpsi <92439990+beer-psi@users.noreply.github.com>
Co-authored-by: Tristan <tristan@tnet.moe>
Co-authored-by: aboudiom59 <51856879+aboudiom59@users.noreply.github.com>
Co-authored-by: noname2noname <noname2noname@protonmail.com>
Co-authored-by: Artur Lapot <51725946+Lapot300@users.noreply.github.com>
Co-authored-by: Manga Download (Owner) <147331778+manga-download-owner@users.noreply.github.com>
Co-authored-by: kiseki999 <102393549+kiseki999@users.noreply.github.com>
Co-authored-by: Kazora <quacmichael@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronny1982 ronny1982 ronny1982 left review comments

@MikeZeDev MikeZeDev MikeZeDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bazket571 @MikeZeDev @ronny1982