New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elf support #971

Merged

mr-tz merged 8 commits into mandiant:elf-support from c-urly:elf-support

Apr 3, 2024

Contributor

c-urly commented Mar 14, 2024

No description provided.

google-cla bot commented Mar 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

c-urly force-pushed the elf-support branch from 1b75077 to 0f99168 Compare

March 14, 2024 16:14

c-urly marked this pull request as ready for review

March 14, 2024 16:16

Contributor Author

c-urly commented Mar 14, 2024

Hi @mr-tz , rebased elf-support branch. Please review new changes and let me know if i need to do anything else to enable CI test?

Collaborator

mr-tz commented Mar 14, 2024

Please address the CI code_styles first.

Contributor Author

c-urly commented Mar 14, 2024 •

edited

Loading

Please address the CI code_styles first.

Sure. I was not bale to run pre-commit checks in local, some issue with the environment. Will try to fix that and update.

c-urly force-pushed the elf-support branch from 0f99168 to ad03ea5 Compare

March 14, 2024 17:57

mr-tz reviewed

View reviewed changes

floss/main.py Outdated Show resolved Hide resolved

mr-tz reviewed

View reviewed changes

floss/main.py Outdated Show resolved Hide resolved

Contributor Author

c-urly commented Mar 17, 2024

Hi @mr-tz ,
Please check the changes, Also i have changed the SUPPORTED_FILE_MAGIC const to dictionary to facilitate File type checking.
I was thinking to get the file type in main and pass it as parameters to subsequent functions?

Thanks,
c-urly

mr-tz reviewed

View reviewed changes

floss/main.py Outdated Show resolved Hide resolved

mr-tz reviewed

View reviewed changes

floss/main.py Outdated Show resolved Hide resolved

mr-tz reviewed

View reviewed changes

floss/main.py Outdated Show resolved Hide resolved

Contributor Author

c-urly commented Mar 21, 2024

@mr-tz , If this looks good to you then I will rebase it will master.

VascoSch92 reviewed

View reviewed changes

floss/main.py Outdated Show resolved Hide resolved

c-urly force-pushed the elf-support branch from d81503a to 4156290 Compare

March 21, 2024 09:12

mr-tz reviewed

View reviewed changes

floss/main.py Outdated Show resolved Hide resolved

floss/main.py Outdated Show resolved Hide resolved

floss/main.py Outdated Show resolved Hide resolved

floss/main.py Outdated Show resolved Hide resolved

mr-tz reviewed

View reviewed changes

floss/main.py Outdated Show resolved Hide resolved

floss/main.py Outdated Show resolved Hide resolved

floss/main.py Outdated Show resolved Hide resolved

c-urly added 8 commits

March 24, 2024 01:59


          ELF support

452cf44


          Refactor is_supported_file_type to get_file_type

e04d9ec

Changed SUPPORTED_FILE_MAGIC to dictionary
Only PE file signature will be read
Go and rust support for only PE files.


          Re-formatted the code

8a1b124


          ELF Support

4929e4f


          Raise error on unsupported file type and shellcode format.

1c369a5


          Corrected Doc string in get_file_type

06c0543


          Added Unsupported file magic

32c6d39


          minor fixes

775635d

c-urly force-pushed the elf-support branch from 04e9c6a to 775635d Compare

March 24, 2024 06:14

Contributor Author

c-urly commented Apr 3, 2024

Hi @mr-tz , Is this fine?

mr-tz approved these changes

View reviewed changes

Collaborator

mr-tz left a comment

thank you

mr-tz merged commit 67018b5 into mandiant:elf-support

10 checks passed

mr-tz pushed a commit that referenced this pull request


          Elf support (#971)

315ffd2

* ELF support

mr-tz pushed a commit that referenced this pull request


          Elf support (#971)

* ELF support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet