extract extra offset/number features #977
Conversation
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
CHANGELOG updated or no update needed, thanks! 😄
|
tests pass on IDA:
|
|
ready for review and merge |
| @@ -29,6 +29,10 @@ def get_value_str(self): | |||
| return capa.render.utils.hex(self.value) | |||
|
|
|||
|
|
|||
| # max recognized structure size (and therefore, offset size) | |||
| MAX_STRUCTURE_SIZE = 0x10000 | |||
There was a problem hiding this comment.
I find this pretty big. How did you pick this value?
There was a problem hiding this comment.
i wanted a round number large than structures/arrays i commonly work with. since 0x1000 is PAGE_SIZE, the next choice was 0x10000. happy to change if necessary.
There was a problem hiding this comment.
ok, makes sense and I'm fine keeping it as is
closes #320
closes #925
TODO:
Checklist