Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix encrypt-data-using-salsa20-or-chacha.yml #886

Merged
merged 3 commits into from
Mar 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions nursery/encrypt-data-using-salsa20-or-chacha.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,14 @@ rule:
# The constant words spell "expand 32-byte k" in ASCII (i.e. the 4 words are "expa", "nd 3", "2-by", and "te k")
- or:
- description: part of key setup
- string: "expand 32-byte k = sigma"
- string: "expand 16-byte k = tau"
- string: "expand 32-byte k"
description: sigma
- string: "expand 16-byte k"
description: tau
Comment on lines -18 to +21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😟

# if sigma and tau are in contiguous memory, may result in concatenated string
- string: "expand 32-byte kexpand 16-byte k"
- bytes: 65 78 70 61 6E 64 20 33 32 2D 62 79 74 65 20 6B = "expand 32-byte k"
- bytes: 65 78 70 61 6E 64 20 31 36 2D 62 79 74 65 20 6B = "expand 16-byte k"
Comment on lines 23 to +25
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string is not guaranteed to be null-terminated.

- and:
- string: "expa"
- string: "nd 3"
Expand Down
Loading