Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU_* macros #828

Merged
merged 8 commits into from
Apr 5, 2023
Merged

CPU_* macros #828

merged 8 commits into from
Apr 5, 2023

Conversation

no92
Copy link
Member

@no92 no92 commented Apr 3, 2023 •
edited
Loading

Closes #710.

@no92 no92 force-pushed the cpu-memes branch 9 times, most recently from 7e8bef5 to 3c76d62 Compare April 3, 2023 20:36
Geertiebear
Geertiebear requested changes Apr 5, 2023
View reviewed changes
options/posix/include/pthread.h Outdated Show resolved Hide resolved
@no92 no92 force-pushed the cpu-memes branch 3 times, most recently from c4aaeef to 95b3098 Compare April 5, 2023 20:37
@no92 no92 marked this pull request as ready for review April 5, 2023 22:50
@no92 no92 changed the base branch from master to abi-break April 5, 2023 22:51
Dennisbonke
Dennisbonke requested changes Apr 5, 2023
View reviewed changes
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside a few styling issues.

options/internal/include/bits/cpu_set.h Outdated Show resolved Hide resolved
options/linux/include/bits/linux/cpu_set.h Outdated Show resolved Hide resolved
options/posix/include/pthread.h Outdated Show resolved Hide resolved
@no92 no92 force-pushed the cpu-memes branch 3 times, most recently from 33ac658 to 8b90572 Compare April 5, 2023 23:36
Dennisbonke
Dennisbonke approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dennisbonke Dennisbonke merged commit 2e4cccd into managarm:abi-break Apr 5, 2023
@no92 no92 deleted the cpu-memes branch April 5, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geertiebear Geertiebear Geertiebear requested changes

@Dennisbonke Dennisbonke Dennisbonke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@no92 @Geertiebear @Dennisbonke