options/posix: port musl regex engine #511
Conversation
dd95cc3 to
32a59a3
Compare
| #include <assert.h> | ||
|
|
||
| int main(void) { | ||
| char *testString = "mlibc is the best best best libc"; |
There was a problem hiding this comment.
singing hard praise for a WIP project :P
| @@ -305,3 +306,6 @@ void globfree(glob_t *g) | |||
| g->gl_pathc = 0; | |||
| g->gl_pathv = NULL; | |||
| } | |||
|
|
|||
| // weak_alias(glob, glob64); | |||
| // weak_alias(globfree, globfree64); | |||
options/posix/meson.build
Outdated
| 'musl-generic-regex/tre-mem.c', | ||
| pic: true, | ||
| include_directories: libc_include_dirs, | ||
| c_args: ['-Wno-unused', '-Wno-implicit', '-Wno-parentheses', '-Wno-sign-compare', '-Wno-attributes', '-Wno-unknown-pragmas', '-Wno-implicit-fallthrough'] |
| @@ -18,7 +18,7 @@ | |||
| #include <stdlib.h> | |||
| #include <wchar.h> | |||
| #include <wctype.h> | |||
| //#include "locale_impl.h" | |||
| // #include "locale_impl.h" | |||
There was a problem hiding this comment.
Why not just simply remove this?
|
Repeating what I said on Discord: I've commented out lines / not fixed warnings so that pulling future changes from musl will be marginally more straightforward. I don't think fixing the warnings is a good idea; it'll just create more pain. |
|
Yes, fixing the warnings would probably be quite annoying. I wonder if we should simply add |
I'm not against that, but we should probably do that in a separate PR |
dc903cc to
56efca3
Compare
|
Probably not, fetching musl at build time seems silly. |
Fixes #98.