Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes on the way to wine #374

Merged
merged 6 commits into from
Jun 6, 2022
Merged

Conversation

Dennisbonke
Copy link
Member

@Dennisbonke Dennisbonke commented Feb 8, 2022

This PR adds various constants, defines, structs and functions that wine requires. It certainly isn’t everything but this can already get reviewed and merged.

Has an abi-break counterpart in #452, which is not required for this to be merged, but is required for wine.
Also includes some fixes for Chromium incidentially, so part of the Chromium on Managarm project.

@Dennisbonke Dennisbonke changed the base branch from master to abi-break February 8, 2022 20:58
@Dennisbonke Dennisbonke changed the base branch from abi-break to master February 8, 2022 20:58
@Dennisbonke Dennisbonke marked this pull request as draft February 8, 2022 22:32
@avdgrinten
Copy link
Member

Renaming functions is an ABI break.

Copy link
Member

@Geertiebear Geertiebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
@Geertiebear Geertiebear merged commit 484691d into managarm:master Jun 6, 2022
@Dennisbonke Dennisbonke deleted the wine branch April 8, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants