add new extcodehash common test (#718)

* add new extcodehash common test * fix skipped tests
mana-ethereum · Dec 11, 2018 · fc6a8d8 · fc6a8d8
1 parent 8d059dd
commit fc6a8d8
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -148,7 +148,7 @@ Ethereum common tests are created for all clients to test against. See the [comm
 | TangerineWhistle  | 100% (1270/1270)          | 100% (1120/1120)            | ✓         |
 | SpuriousDragon    | 100% (1201/1201)          | 100% (1180/1180)            | ✓         |
 | Byzantium         | 100% (4954/4954)          | 100% (4800/4800)            | ✓         |
-| Constantinople    | 100% (10600/10600)        | 100% (10565/10565)          | ✓         |
+| Constantinople    | 99.9% (10600/10601)       | 99.9% (10565/10565)         |           |
 
 View the community [Constantinople Project Tracker](https://github.com/ethereum/pm/issues/53).
 

diff --git a/apps/blockchain/test/blockchain/blockchain_state_test.exs b/apps/blockchain/test/blockchain/blockchain_state_test.exs
@@ -7,7 +7,7 @@ defmodule Blockchain.BlockchainStateTest do
 
   @failing_tests %{
     "Byzantium" => [],
-    "Constantinople" => [],
+    "Constantinople" => ["stExtCodeHash/dynamicAccountOverwriteEmpty"],
     "Frontier" => [],
     "Homestead" => [],
     "HomesteadToDaoAt5" => [],

diff --git a/apps/blockchain/test/blockchain_test.exs b/apps/blockchain/test/blockchain_test.exs
@@ -17,7 +17,9 @@ defmodule BlockchainTest do
     "TangerineWhistle" => [],
     "SpuriousDragon" => [],
     "Byzantium" => [],
-    "Constantinople" => [],
+    "Constantinople" => [
+      "GeneralStateTests/stExtCodeHash/dynamicAccountOverwriteEmpty_d0g0v0.json"
+    ],
     "EIP158ToByzantiumAt5" => [],
     "HomesteadToEIP150At5" => [],
     "FrontierToHomesteadAt5" => []

diff --git a/ethereum_common_tests b/ethereum_common_tests
+145 −0		BlockchainTests/GeneralStateTests/stExtCodeHash/dynamicAccountOverwriteEmpty_d0g0v0.json
+78 −0		GeneralStateTests/stExtCodeHash/dynamicAccountOverwriteEmpty.json
+99 −0		src/BlockchainTestsFiller/GeneralStateTests/stExtCodeHash/dynamicAccountOverwriteEmpty_d0g0v0Filler.json
+105 −0		src/GeneralStateTestsFiller/stExtCodeHash/dynamicAccountOverwriteEmptyFiller.yml