(MESS) ti85: improve support for the TI-84 Plus #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds known dump of TI-84 Plus which has been sent to a mess dev and supports enough asic functionality that it boots and runs. Fixed up model enum to match style from the apple2 and used it to add support for where the ti84p differs from the ti84pse. Consolidated code for the 15Mhz calculators so there is less duplicated code between the ti83pse, ti84pse and ti84 support code.
couriersud
referenced
this pull request
Apr 17, 2019
Adjust warning levels and fix a number of topics identified.
Closed
110-kenichi
referenced
this pull request
in 110-kenichi/mame
Nov 22, 2021
lkundrak
added a commit
to lkundrak/mame
that referenced
this pull request
Oct 29, 2023
Otherwise imgtool gets unhappy with IMD images: Starting program: ./imgtool identify ./altos586/SDX-586.IMD ... Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in ?? () mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 mamedev#2 0x000000000024807d in imgtool_floppy_open_internal (stream=..., image=...) at .../src/tools/imgtool/iflopimg.cpp:83 mamedev#3 imgtool_floppy_open (image=..., stream=...) at .../src/tools/imgtool/iflopimg.cpp:101 mamedev#4 0x000000000024bbdf in imgtool::image::internal_open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, createopts=createopts@entry=0x0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:986 mamedev#5 0x000000000024bd19 in imgtool::image::open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:1010 mamedev#6 0x0000000000250413 in evaluate_module (fname=fname@entry=0x2fa610 "./altos586/SDX-586.IMD", module=0x302320, result=@0x7fffffffd4dc: 0) at .../src/tools/imgtool/imgtool.cpp:271 mamedev#7 0x000000000025075f in imgtool::image::identify_file (fname=0x2fa610 "./altos586/SDX-586.IMD", modules=modules@entry=0x7fffffffd5d0, count=127, count@entry=128) at/usr/include/c++/13/bits/unique_ptr.h:199 mamedev#8 0x000000000025382e in cmd_identify (c=0x229d50 <cmds+400>, argc=<optimized out>, argv=0x7fffffffda00) at .../src/tools/imgtool/main.cpp:578 mamedev#9 0x0000000000253efc in main (argc=3, argv=0x7fffffffd9f0) at .../src/tools/imgtool/main.cpp:939 (gdb) up mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 520 int sectors_per_track = callbacks->get_sectors_per_track(floppy, 0, 20); (gdb) print *callbacks $2 = {read_sector = 0x28de1c <imd_read_sector(...)>, write_sector = 0x0, read_indexed_sector = 0x28de03 <imd_read_indexed_sector(...)>, write_indexed_sector = 0x28de35 <imd_write_indexed_sector(...)>, read_track = 0x0, write_track = 0x0, format_track = 0x0, post_format = 0x0, get_heads_per_disk = 0x28dfef <imd_get_heads_per_disk(...)>, get_tracks_per_disk = 0x28dfff <imd_get_tracks_per_disk(...)>, get_sectors_per_track = 0x0, get_track_size = 0x0, get_sector_length = 0x28dd1c <imd_get_sector_length(...)>, get_indexed_sector_info = 0x28d95c <imd_get_indexed_sector_info(...)>, get_track_data_offset = 0x0} (gdb) With patch applied: $ ./imgtool identify ./altos586/SDX-586.IMD imd_vzdos IMD floppy disk image (VZ-DOS format) imd_dgndos IMD floppy disk image (Dragon DOS format)
lkundrak
added a commit
to lkundrak/mame
that referenced
this pull request
Oct 29, 2023
Otherwise imgtool gets unhappy with IMD images: Starting program: ./imgtool identify ./altos586/SDX-586.IMD ... Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in ?? () mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 mamedev#2 0x000000000024807d in imgtool_floppy_open_internal (stream=..., image=...) at .../src/tools/imgtool/iflopimg.cpp:83 mamedev#3 imgtool_floppy_open (image=..., stream=...) at .../src/tools/imgtool/iflopimg.cpp:101 mamedev#4 0x000000000024bbdf in imgtool::image::internal_open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, createopts=createopts@entry=0x0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:986 mamedev#5 0x000000000024bd19 in imgtool::image::open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:1010 mamedev#6 0x0000000000250413 in evaluate_module (fname=fname@entry=0x2fa610 "./altos586/SDX-586.IMD", module=0x302320, result=@0x7fffffffd4dc: 0) at .../src/tools/imgtool/imgtool.cpp:271 mamedev#7 0x000000000025075f in imgtool::image::identify_file (fname=0x2fa610 "./altos586/SDX-586.IMD", modules=modules@entry=0x7fffffffd5d0, count=127, count@entry=128) at/usr/include/c++/13/bits/unique_ptr.h:199 mamedev#8 0x000000000025382e in cmd_identify (c=0x229d50 <cmds+400>, argc=<optimized out>, argv=0x7fffffffda00) at .../src/tools/imgtool/main.cpp:578 mamedev#9 0x0000000000253efc in main (argc=3, argv=0x7fffffffd9f0) at .../src/tools/imgtool/main.cpp:939 (gdb) up mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 520 int sectors_per_track = callbacks->get_sectors_per_track(floppy, 0, 20); (gdb) print *callbacks $2 = {read_sector = 0x28de1c <imd_read_sector(...)>, write_sector = 0x0, read_indexed_sector = 0x28de03 <imd_read_indexed_sector(...)>, write_indexed_sector = 0x28de35 <imd_write_indexed_sector(...)>, read_track = 0x0, write_track = 0x0, format_track = 0x0, post_format = 0x0, get_heads_per_disk = 0x28dfef <imd_get_heads_per_disk(...)>, get_tracks_per_disk = 0x28dfff <imd_get_tracks_per_disk(...)>, get_sectors_per_track = 0x0, get_track_size = 0x0, get_sector_length = 0x28dd1c <imd_get_sector_length(...)>, get_indexed_sector_info = 0x28d95c <imd_get_indexed_sector_info(...)>, get_track_data_offset = 0x0} (gdb) With patch applied: $ ./imgtool identify ./altos586/SDX-586.IMD imd_vzdos IMD floppy disk image (VZ-DOS format) imd_dgndos IMD floppy disk image (Dragon DOS format)
lkundrak
added a commit
to lkundrak/mame
that referenced
this pull request
Oct 29, 2023
…er_track() The crash: Starting program: ./imgtool identify ./altos586/SDX-586.IMD ... Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in ?? () mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 mamedev#2 0x000000000024807d in imgtool_floppy_open_internal (stream=..., image=...) at .../src/tools/imgtool/iflopimg.cpp:83 mamedev#3 imgtool_floppy_open (image=..., stream=...) at .../src/tools/imgtool/iflopimg.cpp:101 mamedev#4 0x000000000024bbdf in imgtool::image::internal_open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, createopts=createopts@entry=0x0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:986 mamedev#5 0x000000000024bd19 in imgtool::image::open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:1010 mamedev#6 0x0000000000250413 in evaluate_module (fname=fname@entry=0x2fa610 "./altos586/SDX-586.IMD", module=0x302320, result=@0x7fffffffd4dc: 0) at .../src/tools/imgtool/imgtool.cpp:271 mamedev#7 0x000000000025075f in imgtool::image::identify_file (fname=0x2fa610 "./altos586/SDX-586.IMD", modules=modules@entry=0x7fffffffd5d0, count=127, count@entry=128) at/usr/include/c++/13/bits/unique_ptr.h:199 mamedev#8 0x000000000025382e in cmd_identify (c=0x229d50 <cmds+400>, argc=<optimized out>, argv=0x7fffffffda00) at .../src/tools/imgtool/main.cpp:578 mamedev#9 0x0000000000253efc in main (argc=3, argv=0x7fffffffd9f0) at .../src/tools/imgtool/main.cpp:939 (gdb) up mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 520 int sectors_per_track = callbacks->get_sectors_per_track(floppy, 0, 20); (gdb) print *callbacks $2 = {read_sector = 0x28de1c <imd_read_sector(...)>, write_sector = 0x0, read_indexed_sector = 0x28de03 <imd_read_indexed_sector(...)>, write_indexed_sector = 0x28de35 <imd_write_indexed_sector(...)>, read_track = 0x0, write_track = 0x0, format_track = 0x0, post_format = 0x0, get_heads_per_disk = 0x28dfef <imd_get_heads_per_disk(...)>, get_tracks_per_disk = 0x28dfff <imd_get_tracks_per_disk(...)>, get_sectors_per_track = 0x0, get_track_size = 0x0, get_sector_length = 0x28dd1c <imd_get_sector_length(...)>, get_indexed_sector_info = 0x28d95c <imd_get_indexed_sector_info(...)>, get_track_data_offset = 0x0} (gdb) With patch applied: $ ./imgtool identify ./altos586/SDX-586.IMD imd_vzdos IMD floppy disk image (VZ-DOS format) imd_dgndos IMD floppy disk image (Dragon DOS format)
lkundrak
added a commit
to lkundrak/mame
that referenced
this pull request
Oct 29, 2023
…er_track() The crash: Starting program: ./imgtool identify ./altos586/SDX-586.IMD ... Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in ?? () mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 mamedev#2 0x000000000024807d in imgtool_floppy_open_internal (stream=..., image=...) at .../src/tools/imgtool/iflopimg.cpp:83 mamedev#3 imgtool_floppy_open (image=..., stream=...) at .../src/tools/imgtool/iflopimg.cpp:101 mamedev#4 0x000000000024bbdf in imgtool::image::internal_open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, createopts=createopts@entry=0x0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:986 mamedev#5 0x000000000024bd19 in imgtool::image::open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:1010 mamedev#6 0x0000000000250413 in evaluate_module (fname=fname@entry=0x2fa610 "./altos586/SDX-586.IMD", module=0x302320, result=@0x7fffffffd4dc: 0) at .../src/tools/imgtool/imgtool.cpp:271 mamedev#7 0x000000000025075f in imgtool::image::identify_file (fname=0x2fa610 "./altos586/SDX-586.IMD", modules=modules@entry=0x7fffffffd5d0, count=127, count@entry=128) at/usr/include/c++/13/bits/unique_ptr.h:199 mamedev#8 0x000000000025382e in cmd_identify (c=0x229d50 <cmds+400>, argc=<optimized out>, argv=0x7fffffffda00) at .../src/tools/imgtool/main.cpp:578 mamedev#9 0x0000000000253efc in main (argc=3, argv=0x7fffffffd9f0) at .../src/tools/imgtool/main.cpp:939 (gdb) up mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 520 int sectors_per_track = callbacks->get_sectors_per_track(floppy, 0, 20); (gdb) print *callbacks $2 = {read_sector = 0x28de1c <imd_read_sector(...)>, write_sector = 0x0, read_indexed_sector = 0x28de03 <imd_read_indexed_sector(...)>, write_indexed_sector = 0x28de35 <imd_write_indexed_sector(...)>, read_track = 0x0, write_track = 0x0, format_track = 0x0, post_format = 0x0, get_heads_per_disk = 0x28dfef <imd_get_heads_per_disk(...)>, get_tracks_per_disk = 0x28dfff <imd_get_tracks_per_disk(...)>, get_sectors_per_track = 0x0, get_track_size = 0x0, get_sector_length = 0x28dd1c <imd_get_sector_length(...)>, get_indexed_sector_info = 0x28d95c <imd_get_indexed_sector_info(...)>, get_track_data_offset = 0x0} (gdb) With patch applied: $ ./imgtool identify ./altos586/SDX-586.IMD imd_vzdos IMD floppy disk image (VZ-DOS format) imd_dgndos IMD floppy disk image (Dragon DOS format)
mizapf
referenced
this pull request
May 1, 2024
* Feed mouse/pen/touch pointer events through UI input manager with Win32 and SDL. * Started migrating UI code to use new API and reworking mouse/touch interaction. * emu/render.cpp: Support pressing multiple clickable layout items simultaneously. * emu/render.cpp: Allow UI elements to be drawn in any window. * emu/rendlay.cpp, luaengine_render.cpp: Added layout view events for pointer input. * ui/ui.cpp: Allow the UI handler to control pointer display. * ui/analogipt.cpp: Added mouse/touch and more keys for navigating field state list. * ui/menu.cpp: Use vertical swipe to scroll and horizontal swipe to adjust. * ui/menu.cpp: Draw after processing input - greatly improves responsiveness. * ui/menu.cpp: Ignore keyboard/gamepad input during pointer actions. * ui/selmenu.cpp: Made left/right info pane arrows repeat when held. * ui/selmenu.cpp: Use middle click to move keyboard focus. * ui/selmenu.cpp: Let filter list scroll if it's too tall, and use a bit of horizontal padding. * ui/selmenu.cpp: Improved divider sizing. * ui/state.cpp: Don't allow clicks to pass through the confirm deletion prompt to the menu. * ui/simpleselgame.cpp: Fixed error message display and graphics/sound status not showing. * ui/simpleselgame.cpp: Allow tap/click to dismiss error message. * ui/utils.cpp: Show UI for choice filters when there are no choices - it's less confusing. * modules/input/input_sdl.cpp: Made scaling for mouse scroll better match RawInput and DirectInput. * modules/input/input_rawinput.cpp: Added support for horizontal scroll axis. * modules/input/input_win32.cpp: Added support for scroll axes and more buttons to mouse/lightgun. * modules/debugger/debugimgui.cpp: Don't fight over events with the UI manager - it breaks menus. * osd/windows/window.cpp: Translate mouse position to window cooridinates for scroll wheel events. * osd/sdl/window.cpp: Supply last mouse position for scroll wheel events if possible. * scripts/build/complay.py: Made zero input mask an error - it was only being used to block clicks.
cuavas
pushed a commit
that referenced
this pull request
Jul 25, 2024
…2582) * Improved some NV Magazine titles. * Removed Removed "R・SYSTEM 3.2 (Japan)", (part of NV Magazine 1996-12). New working software list items (msx2_flop.xml) ---------------------------- NV Hokkaido Vol. 1 (Japan) [file-hunter] NV Magazine 1 (Japan) [file-hunter] NV Magazine 2 (Japan) [file-hunter] NV Magazine #3 (Japan) [file-hunter] NV Magazine 4 (Japan) [file-hunter] NV Magazine #5 (Japan) [file-hunter] NV Magazine #7 (Japan) [file-hunter] NV Magazine #8 (Japan) [file-hunter] NV Magazine #9 (Japan) [file-hunter] NV Magazine #10 (Japan) [file-hunter] NV Magazine #20 (Japan) [file-hunter] NV Magazine #21 (Japan) [file-hunter] NV Magazine #22 (Japan) [file-hunter] NV Magazine #23 (Japan) [file-hunter] NV Magazine #24 (Japan) [file-hunter] NV Magazine #26 (Japan) [file-hunter] NV Magazine 1996-10 (Japan) [file-hunter] NV Magazine 1996-11 (Japan) [file-hunter] NV Magazine 1998-6 (Japan) [file-hunter] NV Magazine 1998-9 (Japan) [file-hunter] NV Magazine 1998-10 (Japan) [file-hunter] NV Magazine 1999-1 (Japan) [file-hunter] NV Magazine 1999-2 (Japan) [file-hunter] NV Magazine 1999-3 (Japan) [file-hunter] NV Magazine 1999-5 (Japan) [file-hunter] NV Magazine 1999-6 (Japan) [file-hunter] NV Magazine 1999-7 (Japan) [file-hunter] NV Magazine 1999-8 (Japan) [file-hunter] NV Magazine 1999-9 (Japan) [file-hunter] NV Magazine 1999-10 (Japan) [file-hunter] NV Magazine 1999-11 (Japan) [file-hunter] NV Magazine 2000-1 (Japan) [file-hunter] NV Magazine 2000-2 (Japan) [file-hunter] NV Magazine 2000-3 (Japan) [file-hunter] NV Magazine 2000-4 (Japan) [file-hunter] NV Magazine 2000-5 (Japan) [file-hunter] NV Magazine 2000-6 (Japan) [file-hunter] NV Magazine 2000-7 (Japan) [file-hunter] NV Magazine 2000-8 (Japan) [file-hunter] NV Magazine 2000-9 (Japan) [file-hunter] NV Magazine 2000-10 (Japan) [file-hunter] NV Magazine 2000-11 (Japan) [file-hunter] NV Magazine 2000-12 (Japan) [file-hunter] NV Magazine 2002-1 (Japan) [file-hunter] NV Magazine 2002-2 (Japan) [file-hunter] NV Magazine 2002-4 (Japan) [file-hunter] NV Magazine 2002-5 (Japan) [file-hunter] NV Magazine SP #2 (Japan) [file-hunter] NV Magazine Special #3 (Japan) [file-hunter] NV Magazine Special #4 (Japan) [file-hunter] NV Magazine Special #6 (Japan) [file-hunter] NV RSDM #4 (Japan) [file-hunter] New software list items marked not working (msx2_flop.xml) ---------------------------- NV Magazine 1996-12 (Japan) [file-hunter] NV Magazine 1998-11 (Japan) [file-hunter] NV Magazine 2001-12 (Japan) [file-hunter] NV Magazine 2002-3 (Japan) [file-hunter]
tabudz
added a commit
to tabudz/mame
that referenced
this pull request
Feb 27, 2025
Throw an error when image width or height is 0. Fixes mozilla/mozjpeg#140, closes mamedev#7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds known dump of TI-84 Plus which has been sent to a mess dev and supports
enough asic functionality that it boots and runs.
Fixed up model enum to match style from the apple2 and used it to add support
for where the ti84p differs from the ti84pse.
Consolidated code for the 15Mhz calculators so there is less duplicated code
between the ti83pse, ti84pse and ti84 support code.