taito_zm.cpp / zsg2.cpp - more improvements #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DSP, Reduce MCFGs, Add device_mixer_interface for sound gain, Add imperfect_features related to DSP, Add notes
zsg2.cpp: implement emphasis filter, this is a noise reduction scheme that amplifies higher frequncies to reduce quantization noise. zsg2.cpp: Add sample interpolation and another adjustable lowpass filter. This seems to be roughly what real hardware does... zsg2.cpp: Improve panning registers and identify DSP output gain registers.
zsg2: Register 0b appears to be status flags [nw] zsg2: Linear ramping probably makes more sense [nw]
…undocumented and not understood
tms57002: Add undocumented instruction saom / raom, they set saturation mode for the ALU. tms57002: Implement MACC pipeline. tms57002: Add callbacks for EMPTY and PC0 pins. tms57002: Add a few unimplemented instructions. tms57002: Proper behavior of CMEM UPLOAD mode. tms57002: Fix an issue where program is not properly loaded if PLOAD is set after a program has already been written.
…will implement that soon [nw]
Pretty much OST quality now. A pretty decent upgrade from how it was previously, I'd say.
zsg2.cpp: Attempt to reduce clicks zsg2.cpp: Made the emphasis filter much more simple. I think this matches hardware, as a filter like this could be implemented with very few gates in hardware. Also reset the filter state when the sample position reaches the start address, this fixes raycris song mamedev#9 taito_zm.cpp: Adjust volume balance, hopefully fixing psyvarrv. I would need hardware recording for proper verification though tms57002: forgot MACC pipelining for some instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zsg2.cpp: Attempt to reduce clicks
zsg2.cpp: Made the emphasis filter much more simple. I think this
matches hardware, as a filter like this could be implemented with
very few gates in hardware. Also reset the filter state when
the sample position reaches the start address, this fixes raycris
song #9
taito_zm.cpp: Adjust volume balance, hopefully fixing psyvarrv.
I would need hardware recording for proper verification though
tms57002: forgot MACC pipelining for some instructions
(This was supposed to go in the previous pull request, but because it was merged too soon you see this stupid commit history below.)