Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides a test to validate the end to end connectivity of routing::Route #81

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

agalbachicar
Copy link
Collaborator

@agalbachicar agalbachicar commented Mar 5, 2024

🎉 New feature

Part of maliput#543
Pairs with maliput/maliput#628

Summary

Provides test coverage to maliput/maliput#628 with the ability to incorporate a concrete maliput backend.

Test it

Via unit tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

…outes.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

- Fix xodr map.
- Adds error serialization to assertions.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Copy link
Collaborator

@liangfok liangfok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed a pass.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
francocipollone
francocipollone previously approved these changes Jul 5, 2024
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@liangfok liangfok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed a pass.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Copy link
Collaborator

@liangfok liangfok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agalbachicar agalbachicar merged commit eafdd63 into main Oct 8, 2024
3 checks passed
@agalbachicar agalbachicar deleted the agalbachicar/#543_route_end_to_end_connectivity branch October 8, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants