Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change metadata.create to use set instead of add #284

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Change metadata.create to use set instead of add #284

merged 2 commits into from
Oct 19, 2021

Conversation

Americas
Copy link
Contributor

See #283 for reference.

Replaces metadata add with set, to avoid an extra get operation.

Also removes the binary check, since the Metadata methods already deal with that.

@Americas
Remove binary metadata check
233ac9e 
This check is already done when setting the metadata, no reason to do it twice
@Americas
Change metadata.create to use set instead of add
d35f0b6
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 98.229% when pulling d35f0b6 on Americas:support/update-metadata-create into 73b57b5 on malijs:master.

@anonrig anonrig merged commit 3e70c03 into malijs:master Oct 19, 2021
@Americas Americas deleted the support/update-metadata-create branch October 19, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Americas @coveralls @anonrig