Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to collectstatic with non-default STATICFILES_STORAGE #149

Merged
merged 3 commits into from
Jan 27, 2017
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions leaflet/tests/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import json

import django
from django.contrib.staticfiles.storage import StaticFilesStorage, staticfiles_storage
from django.contrib.staticfiles.templatetags.staticfiles import static
from django.test import SimpleTestCase
from django.contrib.gis.db import models as gismodels

Expand All @@ -15,6 +17,44 @@
from ..forms import fields


class DummyStaticFilesStorage(StaticFilesStorage):

def url(self, name):
raise ValueError


class AppLoadingTest(SimpleTestCase):

def test_init_with_non_default_staticfiles_storage(self):
"""
Non-default STATICFILES_STORAGE (ex. django.contrib.staticfiles.storage.ManifestStaticFilesStorage)
might raise ValueError when file could not be found by this storage and DEBUG is set to False.

Ensure that _normalize_plugins_config calls `static` lazily, in order to let `collectstatic` command to run.

"""

try:
with self.settings(STATICFILES_STORAGE='leaflet.tests.tests.DummyStaticFilesStorage', STATIC_ROOT="/", DEBUG=False):
staticfiles_storage._setup() # reset already initialized (and memoized) default STATICFILES_STORAGE

try:
static("a")
self.fail("static must raise an exception")
except ValueError:
pass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like self.assertRaises instead ?


PLUGINS.update({
'a': {'css': 'a'},
})

PLUGINS.pop('__is_normalized__')
_normalize_plugins_config()
finally:
staticfiles_storage._setup()
_normalize_plugins_config()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add some comments to explain what's expected behaviour we should have here



class PluginListingTest(SimpleTestCase):

def test_default_resources(self):
Expand Down