Unit tests for #178 #179
Merged
Unit tests for #178 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and missing mapfile
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…sure the counts are accurate, fixed some quorum related bugs, updated tests to include verifying the counters are correct
… errors are located in the configuration files
…e of exception messages in canfix mapping that use the metadata and added two tests to check that the output of the exceptions correctly reports the filename, line and column of the configuration error
…g info, added new option in mapfile to ignore invalid fixids, the code already silently ignored them, this is the first step in removing that silent failure by at last making it explicit that it does this. I dislike trying to figure out why something is not working because the application provides no feedback about a problem or inform you that it silently ignores some config errors
…t before throwing exception
… dict before it is fully populated, added some debug messages
…d numerous bugs and corner cases so I have addressed most of them. Also improvd the loop detection, I think it will properly identify where the loop is happening but needs more testing
…est.py for shared fixtures in canfix tests, ensure fix database is loaded new for each test
… but should not randomly fail when one can bus transmission goes missing
…and still pass the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.