Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for markdown tables / gfm #378

Merged
merged 6 commits into from
Mar 15, 2022
Merged

Conversation

adamgoth
Copy link
Collaborator

@adamgoth adamgoth commented Mar 14, 2022

What does this PR do?

Fix broken tables in markdown by adding support for tables in remark (github flavored markdown support)

https://unifiedjs.com/learn/recipe/remark-table/

Additional info

This initially broke when remark was updated from v12 to v13 in order to patch a vulnerability

@vercel
Copy link

vercel bot commented Mar 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dux-core-unit/governance-portal-v2/9ksjLZcA3wXyYVcMFLr14UfqQbTk
✅ Preview: https://governance-portal-v2-git-fix-markdown-tabl-3b7c9b-dux-core-unit.vercel.app

@b-pmcg
Copy link
Collaborator

b-pmcg commented Mar 14, 2022

The error in the unit test is related the unified package not being compatible with jest. I tried implementing some of the solutions listed in this comment, but could not get them to work.

@adamgoth adamgoth merged commit 13bf484 into develop Mar 15, 2022
@adamgoth adamgoth deleted the fix/markdown-table-rendering branch March 15, 2022 10:10
@rafinskipg rafinskipg mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants