Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AUTHORS layout #37

Closed
myii opened this issue Mar 25, 2019 · 5 comments · Fixed by #38
Closed

Improve AUTHORS layout #37

myii opened this issue Mar 25, 2019 · 5 comments · Fixed by #38

Comments

@myii
Copy link
Contributor

myii commented Mar 25, 2019

@gaocegege Thanks for this application, finding it very useful. We've forked the repository to make use of more of the available data. You can see how it looks here:

Shall I prepare a PR for you here?
@gaocegege
Copy link
Member

@myii Your fork is really awesome! Welcome PR!

@myii
Copy link
Contributor Author

myii commented Apr 2, 2019

@gaocegege Really sorry, I've been very busy. I'll try to do this during this week sometime.

@gaocegege
Copy link
Member

@myii No worry, Feel free to contribute.

myii added a commit to myii/maintainer that referenced this issue May 24, 2019
@myii
feat(contributor): display more author data in a table
8b306e4 
* Close maintainer-org#37
* Based on forked repo used across SaltStack Formulas organisation, e.g.:
  - https://github.com/saltstack-formulas/template-formula/blob/master/AUTHORS.md
@myii myii mentioned this issue May 24, 2019
Merged
@myii
Copy link
Contributor Author

myii commented May 24, 2019

@gaocegege It took me more than a week! Actually, the recent updates forced me to rebase my fork, so it became an opportunity to prepare PR #38. I hope you like it!

gaocegege pushed a commit that referenced this issue May 25, 2019
@myii @gaocegege
feat(contributor): display more author data in a table (#38)
06db118 
* feat(contributor): display more author data in a table

* Close #37
* Based on forked repo used across SaltStack Formulas organisation, e.g.:
  - https://github.com/saltstack-formulas/template-formula/blob/master/AUTHORS.md

* style(contributor): display `descending` in emphasised text

* refactor(helper): update `Footer` to reformat layout

* Prevent issue with heading appearing in "Table of Contents" when
  automatically converting to display on "Read the Docs" (or similar)
* Other minor reformatting
@gaocegege
Copy link
Member

Thanks for the PR! I like it! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(contributor): display more author data in a table myii/maintainer
2 participants
@gaocegege @myii