chore: Use node 16 for base docker image #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
c19e5a7 to
7349153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The npm docker image is using
node:busteras base image, and that currently points to Node 17 (current, not LTS)Node 17 introduced a new OpenSSL provider and some dependencies do not work with it (though one can set
NODE_OPTIONSto--openssl-legacy-providerin order to use the legacy provider)As the existing workflow is using Node 16, the easiest fix is to just point the base image to Node 16, hence this fix.
Fixes #567
Signed-off-by: Pedro Lamas pedrolamas@gmail.com