Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: lockable sliders #412

Merged
merged 28 commits into from
Nov 17, 2021
Merged

Feature: lockable sliders #412

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
9825ed1
fix: replace tab characters by spaces
dw-0 Nov 7, 2021
926c67e
fix: replace tab characters by spaces
dw-0 Nov 7, 2021
59151cb
feature: add lockable sliders
dw-0 Nov 7, 2021
4ca08f5
feat: add lockable sliders
dw-0 Nov 7, 2021
3fa8bf7
Merge branch 'develop' into feature/lockable-sliders
dw-0 Nov 9, 2021
e3abdbb
Merge remote-tracking branch 'origin/feature/lockable-sliders' into f…
dw-0 Nov 9, 2021
6c6b27a
locale: add EN locale for LockSlider and AutoLockSlider features.
dw-0 Nov 10, 2021
ecf9ea6
chore: rename autoLockSliders to lockSliders
dw-0 Nov 10, 2021
0ad3146
refactor: refactor startLockTimer method
dw-0 Nov 14, 2021
3240879
refactor: lockSlidersChanged Watcher
dw-0 Nov 14, 2021
a83eb81
Merge branch 'develop' into feature/lockable-sliders
dw-0 Nov 14, 2021
1246dc9
refactor: remove helper, use new isTouchDevice BaseMixin method instead
dw-0 Nov 14, 2021
67bacff
feat: add lockable sliders to miscellaneous sliders
dw-0 Nov 14, 2021
da1ab48
Merge branch 'develop' into feature/lockable-sliders
dw-0 Nov 15, 2021
bdbc83d
fix: every interaction with the slider resets timeout correctly
dw-0 Nov 16, 2021
2b7ef4a
fix: fix typo
dw-0 Nov 16, 2021
c5be5c3
Merge branch 'develop' into feature/lockable-sliders
dw-0 Nov 17, 2021
87baa93
chore: remove unused import
dw-0 Nov 17, 2021
81463e5
chore: remove unused import
dw-0 Nov 17, 2021
492786b
chore: replace tabs with spaces
dw-0 Nov 17, 2021
88fbd34
chore: replace tabs with spaces / remove trailing newlines
dw-0 Nov 17, 2021
33d968e
refactor: rename name/value pairs to a more appropriate name
dw-0 Nov 17, 2021
7355688
refactor(locale): update EN locale file
dw-0 Nov 17, 2021
c424192
fix: get/set correct store name
dw-0 Nov 17, 2021
6aca6f3
refactor: use "Delay" instead of "Timeout"
dw-0 Nov 17, 2021
690952e
refactor(locale): update EN locale file
dw-0 Nov 17, 2021
987c81b
refactor(locale): update DE locale file
dw-0 Nov 17, 2021
9ff30ae
refactor: rename menuStyle to navigationStyle
dw-0 Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: lockSlidersChanged Watcher 
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
  • Loading branch information
@dw-0
dw-0 committed Nov 14, 2021
commit 3240879fc93312c1519caabd4075dece2081f11f
5 changes: 1 addition & 4 deletions src/components/inputs/ToolSlider.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,9 @@ export default class ToolSlider extends Mixins(BaseMixin) {
if (this.value >= this.processedMax) {
this.processedMax = (Math.ceil(this.value / this.dynamicStep) + 1) * this.dynamicStep
}

//initialize slider lock state on component creation
this.lockSlidersChanged()
}

@Watch('lockSliders')
@Watch('lockSliders', {immediate: true})
lockSlidersChanged(){
if(this.lockSliders && this.isTouchDevice){
this.sliderIsLocked = true
Expand Down