Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to add history items to job queue #1778

Merged
merged 14 commits into from
Feb 15, 2024
Merged

feat: add ability to add history items to job queue #1778

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
18ce886
feat: Add ability to add history item to queue
mdziekon Feb 14, 2024
64e2b4e
feat: Add reusable AddBatchToQueueDialog
mdziekon Feb 14, 2024
cdfe97f
feat: Use AddBatchToQueueDialog in Gcode files panel
mdziekon Feb 14, 2024
390b9ad
feat: Use AddBatchToQueueDialog in History list panel
mdziekon Feb 15, 2024
689d7e7
feat: Use AddBatchToQueueDialog in Status Gcode files
mdziekon Feb 15, 2024
db148f4
feat: Remove dead code & adjust filename creation
mdziekon Feb 15, 2024
01fa0b6
feat: Linting fixes
mdziekon Feb 15, 2024
0fa2604
feat: Add add batch to queue feedback in History
mdziekon Feb 15, 2024
935bba7
feat: History callback safeguards (for completeness)
mdziekon Feb 15, 2024
bf5dd33
feat: Add proper form validation to AddBatchToQueueDialog
mdziekon Feb 15, 2024
c8d02e4
refactor: simplify some code parts
meteyou Feb 15, 2024
c488529
style: add an line break
meteyou Feb 15, 2024
5a4c211
fix: fix addBatch function
meteyou Feb 15, 2024
181fa9e
fix: fix empty job queue output
meteyou Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: Remove dead code & adjust filename creation 
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
  • Loading branch information
@mdziekon
mdziekon committed Feb 15, 2024
commit db148f4c6a50c3763b3d14f0cb8e12105c8ee8f7
14 changes: 4 additions & 10 deletions src/components/panels/GcodefilesPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,8 +1219,11 @@ export default class GcodefilesPanel extends Mixins(BaseMixin, ControlMixin) {
}

openAddBatchToQueueDialog(item: FileStateGcodefile) {
let filename = [this.currentPath, item.filename].join('/')
if (filename.startsWith('/')) filename = filename.slice(1)

this.dialogAddBatchToQueue.isVisible = true
this.dialogAddBatchToQueue.filename = item.filename
this.dialogAddBatchToQueue.filename = filename
}

closeAddBatchToQueueDialog() {
Expand Down Expand Up @@ -1485,15 +1488,6 @@ export default class GcodefilesPanel extends Mixins(BaseMixin, ControlMixin) {
}
</script>

<style scoped>
._spin_button_group {
width: 24px;
margin-top: -6px;
margin-left: -6px;
margin-bottom: -6px;
}
</style>

<style>
/*noinspection CssUnusedSymbol*/
.files-table .v-data-table-header__icon {
Expand Down