refactor: rework of the KlippyState panel #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
|
Language file analysis report:
|
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
|
Language file analysis report:
|
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
|
Language file analysis report:
|
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
|
Language file analysis report:
|
meteyou
approved these changes
Oct 11, 2022
|
I still wished there was an option to add a [POWER PRINTER ON] button in this panel when the MCU is disconnected and the Printer switch is OFF. It would be nice to be welcomed with a on button instead of a RED ERROR when starting the printer... |
|
@LazaroFilm something like this is on our Todo list... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often there is quite a bit confusion about error messages. Users often think, those messages come from Mainsail, although they are either directly coming from Klipper or Moonraker. This PR has the goal to make it a bit more clear where the errors come from. For that, the Klippy State Panel was reworked quite drastically. Depending on the status, different colors were choosen. Additionally, it is now possible to directly download the Klipper and/or Moonraker logfiles from that panel.
A simple title should make it more clear, which component is reporting the corresponding message and in turn make it more clear for the user.
Before:
After:
Signed-off-by: Dominik Willner th33xitus@gmail.com