Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add warnings if gcodes/config root dirs don't exists #1018

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Aug 10, 2022

this pr fix #984

Signed-off-by: Stefan Dej meteyou@gmail.com

null error if no gcode root directory is available

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou marked this pull request as draft August 10, 2022 22:43
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0

@meteyou meteyou marked this pull request as ready for review August 12, 2022 18:26
@meteyou meteyou requested a review from dw-0 August 12, 2022 18:26
Signed-off-by: Stefan Dej <meteyou@gmail.com>
src/locales/en.json Outdated Show resolved Hide resolved
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0

@meteyou meteyou requested a review from dw-0 August 15, 2022 14:02
@meteyou meteyou changed the title feat: add warnings if no gcodes root dir exists feat: add warnings if gcodes/config root dirs don't exists Aug 15, 2022
@meteyou meteyou merged commit 349372f into mainsail-crew:develop Aug 15, 2022
@meteyou meteyou deleted the feat/display-warning-without-root-dirs branch August 15, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid displaying a wrong value for "Free Disk Space"
2 participants