Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ember-CLI to 2.4.2 #935

Closed
wants to merge 1 commit into from

Conversation

clekstro
Copy link
Contributor

This upgrades app dependencies and renames a few files to conform with Ember-CLI's expectations. Should quiet down some of the upgrade noise in the future.

@marcoow
Copy link
Member

marcoow commented Mar 23, 2016

Thanks for this! There's also an in-progress pull request for the same thing: #918 but unfortunately that depends on a bug in ember-cli-blueprint-test-helpers being fixed - not sure whether that's been done yet. Would be great if you could follow-up on that!

@clekstro
Copy link
Contributor Author

Ha, sorry, should totally should have checked first for something similar. This was just part of looking into the test helpers thing we spoke about the other day.

@clekstro
Copy link
Contributor Author

@marcoow Yeah, it looks like that issue is still open. FWIW, my branch passes locally, but is having issues on Travis for some reason. Should I try to investigate and get the build passing (so this could be merged without the helpers changes), or should we wait for that to get fixed downstream and close this in the interim?

@marcoow
Copy link
Member

marcoow commented Mar 23, 2016

@clekstro: it's failing on travis because there we also run the generator tests (which are not run when you only run ember test) and those are failing due to the issue in ember-cli-blueprint-test-helpers. I wouldn't really want to disable those so we'll have to wait until a new version of ember-cli-blueprint-test-helpers gets released - of course we might be able to help with that.

@clekstro
Copy link
Contributor Author

Ok, gotcha. I can close this then. No sense in duplicate PR's.

@clekstro clekstro closed this Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants