Convert to Yarn workspace #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Apr 15, 2020
packages/ember-simple-auth/node_modules/supports-color/package.json
Outdated
Show resolved
Hide resolved
d6212bc to
94215e4
Compare
2dc8e55 to
3f2c76b
Compare
|
It's likely I missed some things and unfortunately this PR is huge but it'd be good to get a second (and third, fourth, …) pair of eyes on this. |
pichfl
reviewed
Apr 15, 2020
|
@marcoow I think some |
3f2c76b to
34a0f02
Compare
Turbo87
reviewed
Apr 20, 2020
packages/ember-simple-auth/tests/unit/mixins/application-route-mixin-test.js
Show resolved
Hide resolved
6d90c5c to
f4d4b37
Compare
f4d4b37 to
0a8ea05
Compare
patsy-issa
reviewed
May 6, 2020
patsy-issa
reviewed
May 7, 2020
…since that is now in a higher level folder
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're starting to make substantial modifications to the codebase that will also significantly change the way that ESA is used in applications (and likely drop support for some older versions of Ember again), we will require significantly different applications to test ESA in (e.g. one using the classic mixins integration, one using ESA via decorators (or another new mechanism), one app using typescript maybe etc.) This PR creates the foundation for that so that we can have as many Ember apps as we want as workspaces that all use the same addon.
TODO
Procfile.clientandProcfile.server– we'll need to update the heroku settings accordingly when merging this