Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch demo from Zeit Now to Heroku #2168

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Switch demo from Zeit Now to Heroku #2168

merged 2 commits into from
Apr 7, 2020

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Apr 6, 2020

Zeit Now drops support for the version 1 tier that we are using and getting it to work with their new version 2 tier was not straight forward so I just switched to Heroku which I find simpler and it's a bit cheaper as well.

This also removes the now package, configs for that and the custom deploy workflow that are all no longer needed. Once this is merged, we will be auto-deploying from master. For now I manually deployed the app to http://demo.ember-simple-auth.com to make sure things work as expected. The API server that reuses the ember-cli mocks is deployed as a separate heroku app.

Once this is merged we should also merge #2169 to update the link on the demo app on ember-simple-auth.com

closes #2165

@marcoow marcoow mentioned this pull request Apr 6, 2020
@marcoow marcoow temporarily deployed to esa-demo April 6, 2020 19:04 Inactive
@marcoow marcoow temporarily deployed to esa-demo April 6, 2020 19:10 Inactive
@marcoow marcoow requested a review from a team April 6, 2020 19:20
@marcoow marcoow marked this pull request as ready for review April 6, 2020 19:20
@marcoow marcoow temporarily deployed to esa-demo April 7, 2020 07:37 Inactive
@marcoow marcoow temporarily deployed to esa-demo-api April 7, 2020 07:37 Inactive
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@marcoow marcoow merged commit da69fcb into master Apr 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the heroku branch April 7, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade demo app to Zeit Now 2
2 participants