Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/remove sopresto code #98

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

MaxwellGarceau
Copy link
Collaborator

@MaxwellGarceau MaxwellGarceau commented Dec 28, 2024

Description of the Change

Remove deprecated sopresto code and any references to sopresto.

Closes #94

How to test the Change

There are no testing instructions other than a full regression test or the E2E testing suite.

Changelog Entry

Removed - Deprecated sopresto code.

Credits

Props @MaxwellGarceau

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions bot added this to the 1.7.0 milestone Dec 28, 2024
@MaxwellGarceau MaxwellGarceau marked this pull request as ready for review December 28, 2024 18:12
@github-actions github-actions bot added the needs:code-review This requires code review. label Dec 28, 2024
@MaxwellGarceau
Copy link
Collaborator Author

@dkotter is okay to merge this to develop or should I tag QA?

@dkotter
Copy link
Collaborator

dkotter commented Jan 2, 2025

@dkotter is okay to merge this to develop or should I tag QA?

This one can skip QA but will go through our normal UAT process before getting merged in. So nothing left for you to worry about here, I'll make sure this moves across our board

@vikrampm1 vikrampm1 modified the milestones: 1.7.0, 1.6.3 Jan 28, 2025
@vikrampm1 vikrampm1 merged commit 8d10e68 into develop Jan 28, 2025
12 checks passed
@vikrampm1 vikrampm1 mentioned this pull request Jan 28, 2025
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated sopresto code
4 participants