Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the PHP warning and hide the form until a list is selected in the settings. #54

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

iamdharmesh
Copy link
Collaborator

Description of the Change

This PR updates the error-handling code to prevent PHP warnings during form submission. Additionally, it includes the following changes:

  • Hide additional settings until a list is selected in the settings.
  • Clear the selected list option upon logout.
  • Hide the signup form on the front end if no list is selected in the settings.

Closes #53

How to test the Change

  1. Log out if you have a Mailchimp account connected.
  2. Log in to your Mailchimp account and connect it.
  3. Verify that all settings remain hidden until a list is selected and saved from the dropdown.
  4. Verify on the front end that no form is visible until a list is selected and saved from the dropdown in the settings.
  5. Select any list from the dropdown and save the settings.
  6. Verify that the form on the front end appears and functions without any issues.

Changelog Entry

Changed - Make the signup form visible only when a list is selected in the settings.
Fixed - Ensure that the signup form submission works correctly without any PHP errors or warnings.

Credits

Props @dkotter @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Sep 11, 2024
@iamdharmesh iamdharmesh added this to the 1.6.0 milestone Sep 11, 2024
@iamdharmesh iamdharmesh linked an issue Sep 11, 2024 that may be closed by this pull request
1 task
@iamdharmesh iamdharmesh requested a review from dkotter September 11, 2024 07:01
Base automatically changed from enhancement/46 to develop September 11, 2024 15:22
@github-actions github-actions bot added the needs:code-review This requires code review. label Sep 11, 2024
@dkotter dkotter merged commit 032b949 into develop Sep 16, 2024
1 check passed
@dkotter dkotter deleted the fix/53 branch September 16, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If no list is selected, the form still shows but doesn't work correctly
3 participants