-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mailchimp Signup Flow #51
Conversation
…ate account page.
/* | ||
This font software is the property of Commercial Type. | ||
|
||
You may not modify the font software, use it on another website, or install it on a computer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we can use this font in this plugin. Got these font files from the "Mailchimp for WooCommerce" plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at their design guidelines, they say:
Drawn custom for Mailchimp, the Means family comes in 4 weights with italics and a set of stylistic alternates
This seems to imply we are safe to use this font but is a question we should ask them cc / @jeffpaul
The notice in this file mentions Commercial Type. Looking at their website, they do list Mailchimp as a client so I'm assuming they are the ones that built this font for Mailchimp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: We have now included "Graphik" fonts as well to match Figma designs.
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me! Going to hold off on in depth testing until we talk with Mailchimp early next week, just in case they have additional direction / changes for us
Correct, we should use
I concur that's best for now and perhaps Mailchimp and Vextras will update the middleware so the timezone field is not required. |
Thank you. |
Update body text to:
Update "Connect account" button text to:
Remove WP footer and instead show Mailchimp footer (probably worth doing across all Settings, OAuth, and Signup Flow screens we can impact):
I'm going to pass on the "EN" language toggle in the top right as once the plugin strings are translated then different versions will appear for those locales. |
Suggestion - 1 I've noticed that on the "Create a New Account" form, both the "Login" and "Back" buttons are missing. To avoid the need for navigating through the left menu bar, it would be more user-friendly to include these buttons on the form itself, allowing users to easily go back or log in without extra steps. Screen.Recording.2024-09-06.at.4.08.12.PM.movAlso same I've observed that on the "Account Already Exists" screen, there is no "Create a New Account" or "Back" buttons are missing. |
Question: |
Thanks for checking on this and sharing feedback.
Since we are not navigating to the 'Create Account' page through a multi-step process, I think it's fine to navigate back using the left menu. However, I'm open to suggestions for improving the UX, such as adding a 'Cancel' button next to the 'Create account' button, linking the header logo to the main settings page, etc. @jeffpaul @dkotter, any suggestions here?
It is expected to not have a 'Create a New Account' button, as the user account already exists. We should show them options to log in. However, we may show a link below that says something like 'Create an account with a different account.' I am open to suggestions here.
As this screenshot shows the Mailchimp website flow and not a plugin-side implementation, I think we're fine here. Additionally, @jeffpaul has already added a note to gather more information on the redirect/back link. Once we have that information, and if any changes are needed on our side, we will update the implementation accordingly. Thank you. |
QA Update ✅I have verified this PR in the I tested the following on this branch:
Mailchimp-login.existing.account.movMailchimp-Create.a.new.account.movTesting Environment
Steps to Test- As mentioned in the PR description.
|
Let's leave the UI here as close to the Figma / Mailchimp's input as feasible. Additional back/close options are items we can assess in a future iteration.
I'm fine with the (un)available buttons / links in the current flows, no need to worry about any additional changes on this topic. |
@iamdharmesh One thing that we discussed in UAT today was the following scenario:
Technically we could look to block someone from using the plugin (basically don't ever show the settings screen) until we verify their account is activated though I don't think we need to do that yet. What I wanted to test is what happens if they don't activate their account but do come back to their settings and try and use the plugin? If things don't work, it would be ideal at that point to show them a message to prompt them to activate their account and probably remove functionality. But in my testing, things work as expected even without them fully activating their account. So for now, I don't think we need to change anything, though I could see a request in the future to at the very least add in an admin notice to try and get users to activate, or even disable all functionality until they activate. I did notice an issue though if no list is selected and they try and add a signup form. I'll open a new Issue around this. |
Hi @dkotter,
Yes, as we are getting auth credentials in the response from the middleware API server, this is expected. Initially, I thought about blocking the settings page options until the account gets activated, but it seemed like bad UX, so I avoided that and matched what we have in the WooCommerce integration.
Yes, I tested the non-activated account during implementation, and it was working as expected. Also, I believe Mailchimp will have a mechanism to disable or remove non-activated accounts after a few days or hours. After that period, the integration will stop working and prompt the user to log in again. However, that message won't contain detailed instructions about account activation. The user response we receive from Mailchimp contains the last_login field, which confirms that the user has activated their account and logged in. We can utilize that field to display a notice prompting them to activate their account if they haven't done so and have directly accessed the plugin settings. However, this scenario will be very rare. Let me know if you think we should display a notice on the settings page until the user logs in to Mailchimp.
Thanks for opening the issue. I will share my findings there and will raise the PR for the same. Thank you. |
We discussed this on a call and I think an easy solution for now is to show an admin notice if an account exists but hasn't been activated yet, prompting the user to go activate their account and warning them that their account may be removed if they don't (and thus they'll lose any subscribers that may have signed up in the mean time) |
…gs page directly.
<div class="notice notice-warning is-dismissible"> | ||
<p> | ||
<?php | ||
esc_html_e( 'Please activate your Mailchimp account to complete the setup. Without activation, the connection to WordPress may be interrupted.', 'mailchimp' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of the Change
PR adds functionality for creating the Mailchimp account from the WordPress admin dashboard. Here are the details of the tasks covered in this PR.
mailchimpapp.com
service. Ensure we properly get the access token and store that in an encrypted formatApart from the changes listed above PR also makes design updates in the header and connect screen to match designs provided in Figma.
Settings for non-connected user:

Create account screen:

Note
mailchimpapp.com
service, we have limited information on the responses for different scenarios. Therefore, I followed the implementation we have in the Mailchimp for WooCommerce plugin.Closes #46
How to test the Change
Changelog Entry
Credits
Props @dkotter, @jeffpaul, @iamdharmesh
Checklist: