-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/when US phone is not included as a merge field in a Mailchimp form it causes fatal error on submission #108
Conversation
QA Update ✅I have verified this PR in the Screen.Recording.2025-01-16.at.7.20.45.PM.movTesting Environment
Steps to Test- As mentioned in the PR description.
|
Regression / Smoke Test Report ✅Tested with the Testing Environment
|
Description of the Change
Fixed a bug causing a fatal PHP error when:
us-phone-fatal-error-when-merge-field-not-included.mov
Closes #103
How to test the Change
The video
us-phone-fatal-error-when-merge-field-not-included.mov
above can be used as a guide for recreating the testing conditions. However, instead of a fatal error you should see a successful form submission.Phone number
Address
I added a conditional check to ensure address fields were included for submission.
With address
Without address
Changelog Entry
Credits
Props @MaxwellGarceau
Checklist:
I have added tests to cover my change.Small change, not worth writing tests