Improve ethers compatibility #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can pass either an array or an object to an ethers.Contract method.
It's much nicer to deal with objects: when testing, you can, for
instance, expect this to pass
```
const arg = {
x: "x",
y: "y",
};
expect(await someContract.identityFunction(arg)).toMatchObject(arg);
```
If you create an array to pass as an argument, then you have to pull out
the attributes that ethers adds dynamically to the Array class, so that
you don't get something like
```
Expected value to equal:
["0xB152A1F545EB049Aae89da0a5216d6546bDCAa83", {"_hex": "0x00"}, {"_hex": "0x02"}, ["0x6Ecbe1DB9EF729CBe972C83Fb886247691Fb6beb", "0xE36Ea790bc9d7AB70C55260C66D52b1eca985f84"], 3, {"_hex": "0x06"}, {"_hex": "0x00"}, [{"_hex": "0x06"}, {"_hex": "0x04"}], "0x0000000000000000000000000000000000000000000000000000000000000001"]
Received:
["0xB152A1F545EB049Aae89da0a5216d6546bDCAa83", {"_hex": "0x00"}, {"_hex": "0x02"}, ["0x6Ecbe1DB9EF729CBe972C83Fb886247691Fb6beb", "0xE36Ea790bc9d7AB70C55260C66D52b1eca985f84"], 3, {"_hex": "0x06"}, {"_hex": "0x00"}, [{"_hex": "0x06"}, {"_hex": "0x04"}], "0x0000000000000000000000000000000000000000000000000000000000000001"]
Difference:
Compared values have no visual difference.
```
This is causerd by the fact that the second object, while it is an
`Array` object, also has a `channelType` attribute, whereas the first is
a pure `Array:
```
console.log((await turbo.getOutcome(turbo.address)).challengeState);
/**
// array values
[ '0x2192af935893421b7a9c52d792b8e175F6486b2b',
BigNumber { _hex: '0x00' },
BigNumber { _hex: '0x02' },
[ '0x6Ecbe1DB9EF729CBe972C83Fb886247691Fb6beb',
'0xE36Ea790bc9d7AB70C55260C66D52b1eca985f84' ],
3,
BigNumber { _hex: '0x06' },
BigNumber { _hex: '0x00' },
[ BigNumber { _hex: '0x06' }, BigNumber { _hex: '0x04' } ],
'0x0000000000000000000000000000000000000000000000000000000000000001',
// object attributes
channelType: '0x2192af935893421b7a9c52d792b8e175F6486b2b',
channelNonce: BigNumber { _hex: '0x00' },
numberOfParticipants: BigNumber { _hex: '0x02' },
participants: [ '0x6Ecbe1DB9EF729CBe972C83Fb886247691Fb6beb',
'0xE36Ea790bc9d7AB70C55260C66D52b1eca985f84' ],
stateType: 3,
turnNum: BigNumber { _hex: '0x06' },
stateCount: BigNumber { _hex: '0x00' },
resolution: [ BigNumber { _hex: '0x06' }, BigNumber { _hex: '0x04' } ],
gameAttributes: '0x0000000000000000000000000000000000000000000000000000000000000001' ]
**/
```
See discussion here: ethers-io/ethers.js#363 `await provider.getSigner().getAddress()` seems to have ether, though it's not clear why?
tomclose
approved these changes
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the provider's default signer
provider.getSigner(0)is meant to fix the nonce-management issue that causes thethe tx doesn't have the correct nonce. account has nonce of: 95 tx has nonce of: 94error.Sadly it still doesn't prevent flickering tests, for which we might have to wait for a fix, or switch to web3 contracts.