Enable much stricter warnings, and turn on warnings as errors #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wha? You removed the oxford semi-colons? 😓 |
|
Over all I'm ok with the changes. It looks like they make the code more consistent and well named, so I'm all for it. Huge thanks to @tonyarnold for this! 🎊🎉 |
|
I know you were fond of the semicolons, but it was time dude. |
|
@casademora if you're happy for me to merge this in, let's do it and then merge this into |
|
I cling to the traditions of my ancestors…
|
|
I BBQ'ed my ancestors in a purifying 🔥, then ate them with some chunky steak fries |
tonyarnold
added a commit
that referenced
this pull request
Nov 19, 2015
Enable much stricter warnings, and turn on warnings as errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this might be a bit contentious, but I'd like to tidy up MR 3 for release at the same time as modernising as much as possible.
Not sure you're going to agree with all of this, @casademora, but it has helped me to write better code (and I'm hoping it will help as I walk through and fix a few things).