relatedByAttribute key was being ignored #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ored. Changed to use the primaryKey as the fallback when the userinfo key is not defined
|
The contents of this patch look good to me, but would you mind indenting the code using the same style as the rest of the project? There's a clang-format configuration provided at the root of the repository, or you can do it by hand (given it's only a few lines). Thanks! |
tonyarnold
added a commit
that referenced
this pull request
Jan 21, 2016
Don't ignore the relatedByAttribute key during import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the relationship in an import, then relatedByAttribute was being ignored. I changed it to use the primary key as the fallback.