Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MR_aggregateOperation methods should return id #709

Closed
semireg opened this issue Mar 18, 2014 · 1 comment
Closed

MR_aggregateOperation methods should return id #709

semireg opened this issue Mar 18, 2014 · 1 comment
Assignees
@tonyarnold
Labels
Bug
Milestone
2.3.0

Comments

@semireg
Copy link

semireg commented Mar 18, 2014

This method currently returns an NSNumber, however, it doesn't always... If you have a date property, min: and max: functions will return NSDate objects. Therefore, the return of these should likely be id.

+ (NSNumber *) MR_aggregateOperation:(NSString *)function onAttribute:(NSString *)attributeName withPredicate:(NSPredicate *)predicate inContext:(NSManagedObjectContext *)context

https://github.com/magicalpanda/MagicalRecord/blob/develop/MagicalRecord/Categories/NSManagedObject/NSManagedObject%2BMagicalAggregation.m#L109
@tonyarnold
Copy link
Contributor

Good point! I'll update it now.

tonyarnold added a commit that referenced this issue Apr 8, 2014
@tonyarnold
Fix return type of aggregate methods — it's not guaranteed to be an N…
390be03 
…SNumber

Closes #709
naqi pushed a commit to naqi/MagicalRecord that referenced this issue Apr 7, 2016
@tonyarnold @naqi
Fix return type of aggregate methods — it's not guaranteed to be an N…
098a53d 
…SNumber

Closes magicalpanda#709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyarnold tonyarnold

Labels
Bug
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
2 participants
@tonyarnold @semireg