Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full screen loader and revert required Magento_SalesRule condition #17

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

Coosos
Copy link
Contributor

@Coosos Coosos commented Mar 15, 2021

Hi,

In this MR I propose to add a full screen loader to avoid clicking on place order before this request starts / ends because the cart can be closed before paymentfee finished execution.

Also, I am removing / revert "require.defined" because magento can throw an exception to the sales rules, thus causing the total information to be incorrect for the payment method.

On the other hand, what is "isLoading" for ?

@mageprince
Copy link
Owner

Hi @Coosos, thank you for your contribution. We will add this improvement in the next version of the module on Magento Marketplace.

On the other hand, what is "isLoading" for?

This is an observable variable. But recently we checked that this is not used anywhere. We will check and remove that or better if you create PR for it.

@mageprince mageprince closed this Mar 24, 2021
@mageprince mageprince reopened this Mar 25, 2021
@mageprince mageprince merged commit 3d0079d into mageprince:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants