Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix payment fee array config #15

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Fix payment fee array config #15

merged 1 commit into from
Feb 20, 2021

Conversation

Coosos
Copy link
Contributor

@Coosos Coosos commented Feb 19, 2021

Description

  • Fix unserialize error when use array config instead of string in config.xml
  • Rename function "_getPaymentFee" to "getPaymentFee" because it does not respect the PSR
  • Use methodFee property as instance cache

@mageprince mageprince merged commit 46e5943 into mageprince:master Feb 20, 2021
@mageprince
Copy link
Owner

Hi @Coosos, thank you for your contribution. We will add this improvement in the next version of the module on Magento Marketplace.

@Coosos Coosos deleted the fix-paymentfee-array-config branch February 20, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mageprince mageprince mageprince approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Coosos @mageprince