Code refactoring

magepal · Oct 8, 2017 · 711a11a · 711a11a
1 parent d466263
commit 711a11a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Helper/Data.php b/Helper/Data.php
@@ -57,7 +57,7 @@ public function getAccountId() {
      * @return float
      */
     public function formatPrice($price){
-        return sprintf('%.2F', $price);
+        return (float)sprintf('%.2F', $price);
     }
 
 

diff --git a/Model/Order.php b/Model/Order.php
@@ -100,10 +100,10 @@ public function getOrderLayer()
                 'event' => 'gtm.orderComplete',
                 'transactionId' => is_numeric($order->getIncrementId()) ? (int)$order->getIncrementId() : $order->getIncrementId(),
                 'transactionAffiliation' => $this->escapeJsQuote($this->_storeManager->getStore()->getFrontendName()),
-                'transactionTotal' => (float)$this->gtmHelper->formatPrice($order->getBaseGrandTotal()),
+                'transactionTotal' => $this->gtmHelper->formatPrice($order->getBaseGrandTotal()),
                 'transactionSubTotal' => $this->gtmHelper->formatPrice($order->getBaseSubtotal()),
-                'transactionShipping' => (float)$this->gtmHelper->formatPrice($order->getBaseShippingAmount()),
-                'transactionTax' => (float)$this->gtmHelper->formatPrice($order->getTaxAmount()),
+                'transactionShipping' => $this->gtmHelper->formatPrice($order->getBaseShippingAmount()),
+                'transactionTax' => $this->gtmHelper->formatPrice($order->getTaxAmount()),
                 'transactionCouponCode' => $order->getCouponCode(),
                 'transactionDiscount' => $this->gtmHelper->formatPrice($order->getDiscountAmount()),
                 'transactionProducts' => $products