Issue #7 - Undefined variable: items

magepal · Jan 16, 2017 · 53c94f0 · 53c94f0
1 parent cb76d13
commit 53c94f0
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 19 deletions.
diff --git a/Model/DataLayer.php b/Model/DataLayer.php
@@ -59,8 +59,11 @@ class DataLayer extends DataObject {
 
 
     /**
-     * @param MessageInterface $message
-     * @param null $parameters
+     * @param \Magento\Framework\App\Action\Context $context
+     * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
+     * @param \Magento\Customer\Model\Session $customerSession
+     * @param \Magento\Checkout\Model\Session $checkoutSession
+     * @param \Magento\Framework\Registry $registry
      */
     public function __construct(
         \Magento\Framework\App\Action\Context $context, 
@@ -100,7 +103,7 @@ public function getVariables() {
      * Add Variables
      * @param string $name
      * @param mix $value
-     * @return MagePal\GoogleTagManager\Model\DataLayer
+     * @return \MagePal\GoogleTagManager\Model\DataLayer
      */
     public function addVariable($name, $value) {
 
@@ -119,13 +122,13 @@ protected function setCategoryDataLayer() {
         if($this->fullActionName === 'catalog_category_view'
            && $_category = $this->_coreRegistry->registry('current_category')
         ) {
-                $category = [];
-                $category['id'] = $_category->getId();
-                $category['name'] = $_category->getName();
-                
-                $this->addVariable('category', $category);
-                
-                $this->addVariable('list', 'category');
+            $category = [
+                'id' => $_category->getId(),
+                'name' => $_category->getName(),
+            ];
+
+            $this->addVariable('category', $category);
+            $this->addVariable('list', 'category');
         }
 
         return $this;
@@ -141,11 +144,12 @@ protected function setProductDataLayer() {
         ) {
             $this->addVariable('list', 'detail');
 
-            $product = [];
-            $product['id'] = $_product->getId();
-            $product['sku'] = $_product->getSku();
-            $product['name'] = $_product->getName();
-            // $this->addVariable('productPrice', $_product->getPrice());
+            $product = [
+                'id' => $_product->getId(),
+                'sku' => $_product->getSku(),
+                'name' => $_product->getName(),
+            ];
+
             $this->addVariable('product', $product);
         }
 
@@ -161,7 +165,6 @@ protected function setCustomerDataLayer() {
             $customer['isLoggedIn'] = true;
             $customer['id'] = $this->_customerSession->getCustomerId();
             $customer['groupId'] = $this->_customerSession->getCustomerGroupId();
-            //$customer['groupCode'] = ;
         } else {
             $customer['isLoggedIn'] = false;
         }
@@ -193,7 +196,7 @@ protected function setCartDataLayer() {
                     'sku' => $item->getSku(),
                     'name' => $item->getName(),
                     'price' => $item->getPrice(),
-                    'quantity' => $item->getQty()
+                    'quantity' => $item->getQty(),
                 ];
             }
 

diff --git a/composer.json b/composer.json
@@ -16,7 +16,7 @@
         "magento/framework": "100.0.*|100.1.*"
     },
     "type": "magento2-module",
-    "version": "1.2.1",
+    "version": "1.2.2",
     "license": [
         "OSL-3.0",
         "AFL-3.0"

diff --git a/etc/module.xml b/etc/module.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="MagePal_GoogleTagManager" setup_version="1.2.1">
+    <module name="MagePal_GoogleTagManager" setup_version="1.2.2">
         <sequence>
             <module name="Magento_Store"/>
         </sequence>