Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .DS_Store to .gitignore for Mac users #9892

Merged
merged 1 commit into from
Jun 9, 2017

Conversation

woutersamaey
Copy link
Contributor

@woutersamaey woutersamaey commented Jun 9, 2017

Description

Added .DS_Store to .gitignore for Mac users

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Jun 9, 2017
@ishakhsuvarov ishakhsuvarov added this to the June 2017 milestone Jun 9, 2017
@hostep
Copy link
Contributor

hostep commented Jun 9, 2017

Why not add it to your global git config instead of specifying this per project?
See: #7608 (comment)

@ishakhsuvarov
Copy link
Contributor

@hostep I assume this may still be a nice addition for people who did not configure it globally and would not hurt anyone.

@hostep
Copy link
Contributor

hostep commented Jun 9, 2017

Ok, no problem, it can join all the phpstorm, netbeans, ... ignores.

(In my opinion, a .gitignore file should only ignore specific files to the project, if you want to ignore something based on your environment, like based on your OS, or which IDE you are using, you should put it in your global gitignore file).

But indeed, it won't hurt anyone, go ahead :)

@magento-team magento-team merged commit 15d9415 into magento:develop Jun 9, 2017
@orlangur
Copy link
Contributor

@hostep except it will hurt https://insight.sensiolabs.com/what-we-analyse check if we ever use one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants