use payment method name to make checkbox of agreements more unique #6207 #9717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-team
pushed a commit
that referenced
this pull request
May 27, 2017
magento-team
pushed a commit
that referenced
this pull request
May 27, 2017
[EngCom] Public Pull Requests - MAGETWO-69379 use payment method name to make checkbox of agreements more unique #6207 #9717 - MAGETWO-69378 #4272: v2.0.4 Credit memos with adjustment fees cannot be fully refunded with a second credit memo #9715 - MAGETWO-69375 Can't delete last item in cart if Minimum Order is Enable #6151 #9714 - MAGETWO-69230 #7279 bill-to name and ship-to name truncated to 20 chars #9654 - MAGETWO-69155 Fix coding standard in Magento AdminNotification module #9627
|
@bka thank you for your contribution. Your Pull Request has been successfully merged |
|
@bka Thank you for the contribution |
hostep
pushed a commit
to hostep/magento2
that referenced
this pull request
Feb 7, 2018
… make checkbox of agreements more unique magento#6207 magento#9717 (cherry picked from commit 14b9b98)
4 tasks
|
I am running version 2.2.0 and there is still an issue here, specifically with Braintree (core module) stored card details. If you store more than 1 card in your account then the issue occurs again where multiple agreement checkboxes have the same ID: agreement_braintree_cc_vault_1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, html id for agreement checkboxes are built using
But if you have more than one payment method enabled, these checkbox items appear multiple times and html id appears multiple times and is not unique anymore, which introduces some issues for css styling.
Suggested fix is to use the method name of the current payment method for making this id more unique. However, the way of accessing the parent payment method through ko context parent seems ugly, any other idea, on how to do it?
Fixed Issues (if relevant)
Manual testing scenarios
See steps to reproduce in #6207
Contribution checklist