Update laminas-code to ^3.5.1 to be PHP8 compatible

[hws47a]

Description (*)

Update laminas-code to ^3.5.1 to be PHP8 compatible

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/513

Fixed Issues (if relevant)

1. Fixes Update laminas/laminas-code dependency version to "^3.5.1" #31345

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @hws47a. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[hws47a]

In Static Tests:

1) Warning
The data provider specified for Magento\Test\Integrity\PublicCodeTest::testAllPHPClassesReferencedFromPublicClassesArePublic is invalid.
PHPUnit\Framework\Exception: Warning: Use of undefined constant T_NAME_FULLY_QUALIFIED - assumed 'T_NAME_FULLY_QUALIFIED' (this will throw an Error in a future version of PHP) in /var/www/html/vendor/laminas/laminas-code/src/Scanner/ClassScanner.php:1002.
/var/www/html/dev/tests/static/framework/bootstrap.php:62
/var/www/html/vendor/laminas/laminas-code/src/Scanner/ClassScanner.php:1002
/var/www/html/vendor/laminas/laminas-code/src/Scanner/ClassScanner.php:190
/var/www/html/dev/tests/static/testsuite/Magento/Test/Integrity/PublicCodeTest.php:152

This is the issue with backwards compatibility in laminas-code v3.5.1. I'll create a PR to their repo a bit later and hope it'll be fixed.

They say that in 3.5.1 they cannot guarantee that it'll work in PHP 8.0 while in 4.0.0 they dropped support of PHP 7.3

[ihor-sviziev]

@hws47a if that constant was removed - maybe it was just moved somewhere? If so - we can use our own private constant

[hws47a]

I've created a PR for laminas-code 3.5.x branch. Let's see how it'll go and if slowly we may temporary define constants in Magento

[hws47a]

@magento run all tests

[ihor-sviziev]

Please resolve conflicts. Seems like that's causing test failures

[ihor-sviziev]

@magento run Functional Tests B2B

[ihor-sviziev]

Could you fix one small issue and squash your changes to single commit?

[ihor-sviziev]

@magento run all tests

[hws47a]

@magento run all tests

[ihor-sviziev]

@magento run Functional Tests B2B

[hws47a]

@ihor-sviziev all checks finally passed. Thank you

[m2-assistant]

Hi @hws47a, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.