Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1691: Add filter placeholders and Display mode options to category grid #29404

Conversation

joweecaquicla
Copy link

Description (*)

This PR will implement the filter placeholders and add the display mode options to category grid.

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes Add filter placeholders and Display mode options to category grid adobe-stock-integration#1691

Manual testing scenarios (*)

  1. Open https:///admin/media_gallery_catalog/category/index
  2. Expand Filters
  3. The filters must have placeholders and Display Mode filter must be a select with options.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Hazel Joie Caquicla and others added 3 commits August 5, 2020 18:47
Merge changes from origin repo
…91-add-filter-placeholders-and-display-mode-options-to-category-grid
…play mode options to category grid - added placeholder to filters and options to display mode in media gallery category grid
@m2-assistant
Copy link

m2-assistant bot commented Aug 5, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@joweecaquicla
Copy link
Author

@magento run all tests

sivaschenko
sivaschenko previously approved these changes Aug 5, 2020
@ghost ghost assigned sivaschenko Aug 5, 2020
@ghost ghost removed the Progress: pending review label Aug 5, 2020
@sivaschenko sivaschenko added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Progress: pending review labels Aug 5, 2020
@sivaschenko sivaschenko added the Priority: P3 May be fixed according to the position in the backlog. label Aug 5, 2020
@ghost ghost dismissed sivaschenko’s stale review August 5, 2020 13:05

Pull Request state was updated. Re-review required.

@sivaschenko sivaschenko added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Aug 5, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-7959 has been created to process this Pull Request

@chalov-anton chalov-anton self-assigned this Aug 6, 2020
@chalov-anton
Copy link
Contributor

✔️ QA Passed

cat_place_hold

Test on Cucumber Studio - https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/4938623

@chalov-anton chalov-anton added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 6, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2020
@magento-engcom-team magento-engcom-team merged commit 967d484 into magento:2.4-develop Aug 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 8, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryCatalogUi Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add filter placeholders and Display mode options to category grid
4 participants