Update code to reduce redundancy and simplify readability #28608

df2k2 · 2020-06-08T03:02:48Z

Simplified code complexity by optimizing logic, redundant variable assignments, over-usage of returns within a function. Eliminated needless and redundant variable assignment.

Description (*)

Simplifying logic and readability randomly

Manual testing scenarios (*)

Modified functions are simpler yet do not change any logic within lib/internal/Magento/Framework/App/Request/Http.php

Questions or comments

No.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Update code to reduce redundancy and simplify readability #29381: Update code to reduce redundancy and simplify readability

m2-assistant · 2020-06-08T03:02:50Z

Hi @df2k2. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz

Thank you for your contribution. Please review my Code Review comments.

lib/internal/Magento/Framework/App/Request/Http.php

Co-authored-by: Lukasz Bajsarowicz <lukasz.bajsarowicz@gmail.com>

df2k2

Updated

lbajsarowicz · 2020-06-13T22:55:03Z

@magento run all tests
Good afternoon @df2k2 , I'm running tests to make sure that everything works fine with your PR. If there are no issues, I am going to approve your changes and soon, all the changes should be processed by Core Team.

lbajsarowicz · 2020-06-14T00:59:09Z

@magento run Functional Tests CE

Looks like the failing test is flaky one. Trying to re-run it and in the meantime, I'm accepting the PR.

lbajsarowicz

✔️ Thank you for your contribution!

magento-engcom-team · 2020-06-14T01:03:12Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7680 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Echo · 2020-07-28T14:20:52Z

@magento run all tests

lbajsarowicz

✔️ Thanks for your input.

magento-engcom-team · 2020-08-04T11:51:42Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7680 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Alfa · 2020-08-04T13:14:33Z

@lbajsarowicz Could you put an appropriate label for test coverage?
Thanks!

lbajsarowicz · 2020-08-04T13:23:22Z

@engcom-Alfa This class is one of the most-covered ones, that is the result of the dependencies relying on this class.

engcom-Alfa · 2020-08-04T13:37:26Z

✔️ QA Passed
Was checked general cases ( create orders as guest and customer, register new customer, wishlist, and compare products) and everything works as expected.

engcom-Alfa · 2020-08-04T13:38:43Z

@magento create issue

…#28608

m2-assistant · 2020-08-08T06:57:27Z

Hi @df2k2, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Update code to reduce redundancy and simplify readability

01309d8

ghost added the Progress: pending review label Jun 8, 2020

magento-engcom-team added Component: App Release Line: 2.4 labels Jun 8, 2020

lbajsarowicz suggested changes Jun 8, 2020

View reviewed changes

ghost assigned lbajsarowicz Jun 8, 2020

ghost added Progress: needs update and removed Progress: pending review labels Jun 8, 2020

df2k2 and others added 3 commits June 8, 2020 10:30

Update lib/internal/Magento/Framework/App/Request/Http.php

45a668a

Co-authored-by: Lukasz Bajsarowicz <lukasz.bajsarowicz@gmail.com>

Update based on review for getBeforeForwardInfo

0a1b76a

Updated based on comments

910da38

df2k2 commented Jun 8, 2020

View reviewed changes

df2k2 requested a review from lbajsarowicz June 12, 2020 12:59

Merge branch '2.4-develop' into patch-1

9009851

lbajsarowicz approved these changes Jun 14, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jun 14, 2020

Merge branch '2.4-develop' into patch-1

9b954c0

VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 18, 2020

engcom-Delta self-assigned this Jul 7, 2020

ghost removed the Progress: ready for testing label Jul 7, 2020

engcom-Echo force-pushed the patch-1 branch from 300b4c5 to 7e7b645 Compare July 28, 2020 14:12

engcom-Echo requested a review from lbajsarowicz August 4, 2020 11:46

lbajsarowicz approved these changes Aug 4, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 4, 2020

engcom-Alfa self-assigned this Aug 4, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 4, 2020

lbajsarowicz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 4, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 4, 2020

m2-assistant bot mentioned this pull request Aug 4, 2020

[Issue] Update code to reduce redundancy and simplify readability #29381

Closed

4 tasks

engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 4, 2020

ghost added Progress: accept and removed Progress: extended testing labels Aug 4, 2020

magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2020

ENGCOM-7680: Update code to reduce redundancy and simplify readability …

71d4cd6

…#28608

magento-engcom-team merged commit 3c65835 into magento:2.4-develop Aug 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update code to reduce redundancy and simplify readability #28608

Update code to reduce redundancy and simplify readability #28608

df2k2 commented Jun 8, 2020 •

edited by m2-assistant bot

Loading

m2-assistant bot commented Jun 8, 2020

lbajsarowicz left a comment

df2k2 left a comment

lbajsarowicz commented Jun 13, 2020

lbajsarowicz commented Jun 14, 2020

lbajsarowicz left a comment

magento-engcom-team commented Jun 14, 2020

engcom-Echo commented Jul 28, 2020

lbajsarowicz left a comment

magento-engcom-team commented Aug 4, 2020

engcom-Alfa commented Aug 4, 2020 •

edited

Loading

lbajsarowicz commented Aug 4, 2020

engcom-Alfa commented Aug 4, 2020

engcom-Alfa commented Aug 4, 2020

m2-assistant bot commented Aug 8, 2020

Update code to reduce redundancy and simplify readability #28608

Update code to reduce redundancy and simplify readability #28608

Conversation

df2k2 commented Jun 8, 2020 • edited by m2-assistant bot Loading

Description (*)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

m2-assistant bot commented Jun 8, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

df2k2 left a comment

Choose a reason for hiding this comment

lbajsarowicz commented Jun 13, 2020

lbajsarowicz commented Jun 14, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Jun 14, 2020

engcom-Echo commented Jul 28, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Aug 4, 2020

engcom-Alfa commented Aug 4, 2020 • edited Loading

lbajsarowicz commented Aug 4, 2020

engcom-Alfa commented Aug 4, 2020

engcom-Alfa commented Aug 4, 2020

m2-assistant bot commented Aug 8, 2020

df2k2 commented Jun 8, 2020 •

edited by m2-assistant bot

Loading

engcom-Alfa commented Aug 4, 2020 •

edited

Loading