-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed array creation to be in line with the class #28515
Conversation
Make the array creation consistent throughout the class
Hi @litsher. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
@magento run all tests |
@magento run Integration Tests |
Hi @rogyar, thank you for the review. |
@magento run all tests |
@magento create issue |
✔️ QA Passed Was tested Print invoice functionality and everything work as previously (expected). Manual testing scenario:
Actual Result: ✔️ Product names are displayed correctly |
Hi @litsher, thank you for your contribution! |
Make the array creation consistent throughout the class.
This is mostly just a convention fix.
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: