-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when creating a store view if there are CMS pages with the same URL key #28421
Error when creating a store view if there are CMS pages with the same URL key #28421
Conversation
Hi @engcom-Charlie. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
Looks like false positives, but let's restart tests again @magento run Functional Tests B2B, Functional Tests EE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔ Approved
Failing functional tests looks not related to changes from this PR.
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed Manual testing scenario:
Before: ✖️ Error message "Something went wrong while saving. Please review the error log." After: ✔️ Store view created successfully. |
@magento run Functional Tests B2B, Functional Tests EE |
… 28357 � Conflicts: � dev/tests/integration/testsuite/Magento/CmsUrlRewrite/Plugin/Cms/Model/Store/ViewTest.php
@magento run all tests |
…with the same URL key #28421
Hi @engcom-Charlie, thank you for your contribution! |
Description (*)
Fixed issue and covered by test.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
See #28357
Questions or comments
Contribution checklist (*)